* [PATCH] unit-tests/test-lib: fix typo in check_pointer_eq() description
@ 2024-07-29 4:13 Kousik Sanagavarapu
2024-07-29 4:26 ` Eric Sunshine
2024-07-29 4:32 ` [PATCH v2] " Kousik Sanagavarapu
0 siblings, 2 replies; 3+ messages in thread
From: Kousik Sanagavarapu @ 2024-07-29 4:13 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Patrick Steinhardt, Kousik Sanagavarapu
The comment surrounding chech_pointer_eq() should explain about what
this function does instead of explaining check_int(). Correct this.
Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
---
t/unit-tests/test-lib.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/unit-tests/test-lib.h b/t/unit-tests/test-lib.h
index 2de6d715d5..c59f646fd9 100644
--- a/t/unit-tests/test-lib.h
+++ b/t/unit-tests/test-lib.h
@@ -76,8 +76,9 @@ int test_assert(const char *location, const char *check, int ok);
int check_bool_loc(const char *loc, const char *check, int ok);
/*
- * Compare two integers. Prints a message with the two values if the
- * comparison fails. NB this is not thread safe.
+ * Compare the equality of two pointers of same type. Prints a message
+ * with the two values if the equality fails. NB this is not thread
+ * safe.
*/
#define check_pointer_eq(a, b) \
(test__tmp[0].p = (a), test__tmp[1].p = (b), \
--
2.46.0.rc2.1.g1fdd4dfe68
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] unit-tests/test-lib: fix typo in check_pointer_eq() description
2024-07-29 4:13 [PATCH] unit-tests/test-lib: fix typo in check_pointer_eq() description Kousik Sanagavarapu
@ 2024-07-29 4:26 ` Eric Sunshine
2024-07-29 4:32 ` [PATCH v2] " Kousik Sanagavarapu
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sunshine @ 2024-07-29 4:26 UTC (permalink / raw)
To: Kousik Sanagavarapu; +Cc: git, Junio C Hamano, Patrick Steinhardt
On Mon, Jul 29, 2024 at 12:14 AM Kousik Sanagavarapu
<five231003@gmail.com> wrote:
> The comment surrounding chech_pointer_eq() should explain about what
> this function does instead of explaining check_int(). Correct this.
s/chech/check/
> Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] unit-tests/test-lib: fix typo in check_pointer_eq() description
2024-07-29 4:13 [PATCH] unit-tests/test-lib: fix typo in check_pointer_eq() description Kousik Sanagavarapu
2024-07-29 4:26 ` Eric Sunshine
@ 2024-07-29 4:32 ` Kousik Sanagavarapu
1 sibling, 0 replies; 3+ messages in thread
From: Kousik Sanagavarapu @ 2024-07-29 4:32 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Patrick Steinhardt, Eric Sunshine,
Kousik Sanagavarapu
The comment surrounding check_pointer_eq() should explain about what
this function does instead of explaining check_int(). Correct this.
Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
---
t/unit-tests/test-lib.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/unit-tests/test-lib.h b/t/unit-tests/test-lib.h
index 2de6d715d5..c59f646fd9 100644
--- a/t/unit-tests/test-lib.h
+++ b/t/unit-tests/test-lib.h
@@ -76,8 +76,9 @@ int test_assert(const char *location, const char *check, int ok);
int check_bool_loc(const char *loc, const char *check, int ok);
/*
- * Compare two integers. Prints a message with the two values if the
- * comparison fails. NB this is not thread safe.
+ * Compare the equality of two pointers of same type. Prints a message
+ * with the two values if the equality fails. NB this is not thread
+ * safe.
*/
#define check_pointer_eq(a, b) \
(test__tmp[0].p = (a), test__tmp[1].p = (b), \
--
2.46.0.rc2.1.g1fdd4dfe68
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-29 4:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-29 4:13 [PATCH] unit-tests/test-lib: fix typo in check_pointer_eq() description Kousik Sanagavarapu
2024-07-29 4:26 ` Eric Sunshine
2024-07-29 4:32 ` [PATCH v2] " Kousik Sanagavarapu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).