From: David Disseldorp <ddiss@suse.de>
To: git@vger.kernel.org
Subject: [PATCH v2 0/1] notes: fix editor invocation regression
Date: Mon, 29 Jul 2024 17:13:59 +0200 [thread overview]
Message-ID: <20240729151639.19192-1-ddiss@suse.de> (raw)
The following patch attempts to restore previous editor invocation
behavior for empty notes, which was inadvertantly changed via 90bc19b3ae
(notes.c: introduce '--separator=<paragraph-break>' option, 2023-05-27).
A new regression test is included, which passes prior to 90bc19b3ae and
after this fix.
Please cc me in any replies as I'm not subscribed.
Cheers, David
--
The following changes since commit ad57f148c6b5f8735b62238dda8f571c582e0e54:
Git 2.46-rc2 (2024-07-23 16:54:35 -0700)
are available in the Git repository at:
https://github.com/ddiss/git.git notes_empty_editor_add_v2
for you to fetch changes up to 63019aa2c7bbee5989944a990ca2c0229cef8ae2:
notes: do not trigger editor when adding an empty note (2024-07-29 13:22:26 +0200)
----------------------------------------------------------------
David Disseldorp (1):
notes: do not trigger editor when adding an empty note
builtin/notes.c | 22 ++++++++++------------
t/t3301-notes.sh | 5 +++++
2 files changed, 15 insertions(+), 12 deletions(-)
next reply other threads:[~2024-07-29 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 15:13 David Disseldorp [this message]
2024-07-29 15:14 ` [PATCH v2 1/1] notes: do not trigger editor when adding an empty note David Disseldorp
2024-07-29 21:37 ` Junio C Hamano
2024-07-29 21:53 ` David Disseldorp
2024-07-29 22:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729151639.19192-1-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).