From: AbdAlRahman Gad <abdobngad@gmail.com>
To: git@vger.kernel.org
Cc: AbdAlRahman Gad <abdobngad@gmail.com>
Subject: [PATCH v3 0/6] [Newcomer] t7004: modernize the style
Date: Sun, 4 Aug 2024 10:11:31 +0300 [thread overview]
Message-ID: <20240804071137.30326-1-abdobngad@gmail.com> (raw)
- remove whitespace after the redirect operators.
- move number of expect files prepared outside of
test_expect_success to be inside the tests that use it.
- split some lines that have two commands into two lines
one command each.
- turn some "<<\EOF" into "<<-\EOF" and indent their body.
- avoid using pipes in the output from "test-tool ref-store"
and write the output to a file.
- change test_expect_success that are seperated from its name
to be on the same line.
AbdAlRahman Gad (6):
[Newcomer] t7004-tag: redirection operator
[Newcomer] t7004-tag: do not lose exit status to pipe
[Newcomer] t7004-tag: one command per line
[Newcomer] t7004-tag: do not prepare except outside
test_expect_success
[Newcomer] t7004-tag: here-doc modernization
[Newcomer] t7004-tag: description on the same line as
test_expect_success
t/t7004-tag.sh | 584 +++++++++++++++++++++++--------------------------
1 file changed, 274 insertions(+), 310 deletions(-)
base-commit: 406f326d271e0bacecdb00425422c5fa3f314930
--
2.43.0
next reply other threads:[~2024-08-04 7:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 7:11 AbdAlRahman Gad [this message]
2024-08-04 7:11 ` [PATCH v3 1/6] [Newcomer] t7004-tag: redirection operator AbdAlRahman Gad
2024-08-05 9:36 ` Patrick Steinhardt
2024-08-04 7:11 ` [PATCH v3 2/6] [Newcomer] t7004-tag: do not lose exit status to pipe AbdAlRahman Gad
2024-08-05 9:36 ` Patrick Steinhardt
2024-08-04 7:11 ` [PATCH v3 3/6] [Newcomer] t7004-tag: one command per line AbdAlRahman Gad
2024-08-05 9:36 ` Patrick Steinhardt
2024-08-04 7:11 ` [PATCH v3 4/6] [Newcomer] t7004-tag: do not prepare except outside test_expect_success AbdAlRahman Gad
2024-08-04 7:32 ` Eric Sunshine
2024-08-04 9:01 ` AbdAlRahman Gad
2024-08-04 16:46 ` Junio C Hamano
2024-08-04 7:11 ` [PATCH v3 5/6] [Newcomer] t7004-tag: here-doc modernization AbdAlRahman Gad
2024-08-05 9:42 ` Patrick Steinhardt
2024-08-04 7:11 ` [PATCH v3 6/6] [Newcomer] t7004-tag: description on the same line as test_expect_success AbdAlRahman Gad
2024-08-05 9:42 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240804071137.30326-1-abdobngad@gmail.com \
--to=abdobngad@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).