git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: AbdAlRahman Gad <abdobngad@gmail.com>
To: git@vger.kernel.org
Cc: AbdAlRahman Gad <abdobngad@gmail.com>
Subject: [PATCH v3 2/6] [Newcomer] t7004-tag: do not lose exit status to pipe
Date: Sun,  4 Aug 2024 10:11:33 +0300	[thread overview]
Message-ID: <20240804071137.30326-3-abdobngad@gmail.com> (raw)
In-Reply-To: <20240804071137.30326-1-abdobngad@gmail.com>

split "test-tool ... | sed" pipeline into two commands
to avoid losing exit status from test-tool

Signed-off-by: AbdAlRahman Gad <abdobngad@gmail.com>
---
 t/t7004-tag.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index 3100a4c219..1e31f39646 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -97,7 +97,8 @@ test_expect_success 'creating a tag with --create-reflog should create reflog' '
 	test_when_finished "git tag -d tag_with_reflog1" &&
 	git tag --create-reflog tag_with_reflog1 &&
 	git reflog exists refs/tags/tag_with_reflog1 &&
-	test-tool ref-store main for-each-reflog-ent refs/tags/tag_with_reflog1 | sed -e "s/^.*	//" >actual &&
+	test-tool ref-store main for-each-reflog-ent refs/tags/tag_with_reflog1 >actual.body &&
+	sed -e "s/^.*	//" actual.body >actual &&
 	test_cmp expected actual
 '
 
@@ -108,7 +109,8 @@ test_expect_success 'annotated tag with --create-reflog has correct message' '
 	test_when_finished "git tag -d tag_with_reflog2" &&
 	git tag -m "annotated tag" --create-reflog tag_with_reflog2 &&
 	git reflog exists refs/tags/tag_with_reflog2 &&
-	test-tool ref-store main for-each-reflog-ent refs/tags/tag_with_reflog2 | sed -e "s/^.*	//" >actual &&
+	test-tool ref-store main for-each-reflog-ent refs/tags/tag_with_reflog2 >actual.body &&
+	sed -e "s/^.*	//" actual.body >actual &&
 	test_cmp expected actual
 '
 
-- 
2.43.0


  parent reply	other threads:[~2024-08-04  7:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-04  7:11 [PATCH v3 0/6] [Newcomer] t7004: modernize the style AbdAlRahman Gad
2024-08-04  7:11 ` [PATCH v3 1/6] [Newcomer] t7004-tag: redirection operator AbdAlRahman Gad
2024-08-05  9:36   ` Patrick Steinhardt
2024-08-04  7:11 ` AbdAlRahman Gad [this message]
2024-08-05  9:36   ` [PATCH v3 2/6] [Newcomer] t7004-tag: do not lose exit status to pipe Patrick Steinhardt
2024-08-04  7:11 ` [PATCH v3 3/6] [Newcomer] t7004-tag: one command per line AbdAlRahman Gad
2024-08-05  9:36   ` Patrick Steinhardt
2024-08-04  7:11 ` [PATCH v3 4/6] [Newcomer] t7004-tag: do not prepare except outside test_expect_success AbdAlRahman Gad
2024-08-04  7:32   ` Eric Sunshine
2024-08-04  9:01     ` AbdAlRahman Gad
2024-08-04 16:46   ` Junio C Hamano
2024-08-04  7:11 ` [PATCH v3 5/6] [Newcomer] t7004-tag: here-doc modernization AbdAlRahman Gad
2024-08-05  9:42   ` Patrick Steinhardt
2024-08-04  7:11 ` [PATCH v3 6/6] [Newcomer] t7004-tag: description on the same line as test_expect_success AbdAlRahman Gad
2024-08-05  9:42   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240804071137.30326-3-abdobngad@gmail.com \
    --to=abdobngad@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).