git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: AbdAlRahman Gad <abdobngad@gmail.com>
To: git@vger.kernel.org
Cc: AbdAlRahman Gad <abdobngad@gmail.com>
Subject: [PATCH v3 5/6] [Newcomer] t7004-tag: here-doc modernization
Date: Sun,  4 Aug 2024 10:11:36 +0300	[thread overview]
Message-ID: <20240804071137.30326-6-abdobngad@gmail.com> (raw)
In-Reply-To: <20240804071137.30326-1-abdobngad@gmail.com>

use <<-\EOF to indent here-doc

Signed-off-by: AbdAlRahman Gad <abdobngad@gmail.com>
---
 t/t7004-tag.sh | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index 96aa908eaf..c60167d6fd 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -389,10 +389,10 @@ test_expect_success 'tag -l <pattern> -l <pattern> works, as our buggy documenta
 
 test_expect_success 'listing tags in column' '
 	COLUMNS=41 git tag -l --column=row >actual &&
-	cat >expected <<\EOF &&
-a1      aa1     cba     t210    t211
-v0.2.1  v1.0    v1.0.1  v1.1.3
-EOF
+	cat >expected <<-\EOF &&
+	a1      aa1     cba     t210    t211
+	v0.2.1  v1.0    v1.0.1  v1.1.3
+	EOF
 	test_cmp expected actual
 '
 
@@ -400,10 +400,10 @@ test_expect_success 'listing tags in column with column.*' '
 	test_config column.tag row &&
 	test_config column.ui dense &&
 	COLUMNS=40 git tag -l >actual &&
-	cat >expected <<\EOF &&
-a1      aa1   cba     t210    t211
-v0.2.1  v1.0  v1.0.1  v1.1.3
-EOF
+	cat >expected <<-\EOF &&
+	a1      aa1   cba     t210    t211
+	v0.2.1  v1.0  v1.0.1  v1.1.3
+	EOF
 	test_cmp expected actual
 '
 
@@ -414,17 +414,17 @@ test_expect_success 'listing tag with -n --column should fail' '
 test_expect_success 'listing tags -n in column with column.ui ignored' '
 	test_config column.ui "row dense" &&
 	COLUMNS=40 git tag -l -n >actual &&
-	cat >expected <<\EOF &&
-a1              Foo
-aa1             Foo
-cba             Foo
-t210            Foo
-t211            Foo
-v0.2.1          Foo
-v1.0            Foo
-v1.0.1          Foo
-v1.1.3          Foo
-EOF
+	cat >expected <<-\EOF &&
+	a1              Foo
+	aa1             Foo
+	cba             Foo
+	t210            Foo
+	t211            Foo
+	v0.2.1          Foo
+	v1.0            Foo
+	v1.0.1          Foo
+	v1.1.3          Foo
+	EOF
 	test_cmp expected actual
 '
 
-- 
2.43.0


  parent reply	other threads:[~2024-08-04  7:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-04  7:11 [PATCH v3 0/6] [Newcomer] t7004: modernize the style AbdAlRahman Gad
2024-08-04  7:11 ` [PATCH v3 1/6] [Newcomer] t7004-tag: redirection operator AbdAlRahman Gad
2024-08-05  9:36   ` Patrick Steinhardt
2024-08-04  7:11 ` [PATCH v3 2/6] [Newcomer] t7004-tag: do not lose exit status to pipe AbdAlRahman Gad
2024-08-05  9:36   ` Patrick Steinhardt
2024-08-04  7:11 ` [PATCH v3 3/6] [Newcomer] t7004-tag: one command per line AbdAlRahman Gad
2024-08-05  9:36   ` Patrick Steinhardt
2024-08-04  7:11 ` [PATCH v3 4/6] [Newcomer] t7004-tag: do not prepare except outside test_expect_success AbdAlRahman Gad
2024-08-04  7:32   ` Eric Sunshine
2024-08-04  9:01     ` AbdAlRahman Gad
2024-08-04 16:46   ` Junio C Hamano
2024-08-04  7:11 ` AbdAlRahman Gad [this message]
2024-08-05  9:42   ` [PATCH v3 5/6] [Newcomer] t7004-tag: here-doc modernization Patrick Steinhardt
2024-08-04  7:11 ` [PATCH v3 6/6] [Newcomer] t7004-tag: description on the same line as test_expect_success AbdAlRahman Gad
2024-08-05  9:42   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240804071137.30326-6-abdobngad@gmail.com \
    --to=abdobngad@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).