git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: AbdAlRahman Gad <abdobngad@gmail.com>
To: git@vger.kernel.org
Cc: AbdAlRahman Gad <abdobngad@gmail.com>
Subject: [PATCH v6 0/8] [Newcomer] t7004: modernize the style
Date: Thu,  8 Aug 2024 19:31:59 +0300	[thread overview]
Message-ID: <20240808163302.17521-1-abdobngad@gmail.com> (raw)

- Remove whitespace after the redirect operators.

- Move number of expect files prepared outside of
  test_expect_success to be inside the tests that use it.

- Split some lines that have two commands into two lines
  one command each.

- Turn some "<<\EOF" into "<<-\EOF" and indent their body.

- Avoid using pipes in the output from "test-tool ref-store"
  and write the output to a file.

- Change test_expect_success that are seperated from its name
  to be on the same line.

- Avoid separating test Description and test body with backslash

- Use single quotes instead of double quotes for test description and
  body.

- Use write_script which takes care of emitting the `#!/bin/sh` line
  and the `chmod +x`.

There are still tests that could lose exit status to pipe. This needs
to be modernized too, I will fix them in another patch series.

AbdAlRahman Gad (8):
  t7004: remove space after redirect operators
  t7004: one command per line
  t7004: do not prepare things outside test_expect_success
  t7004: use indented here-doc
  t7004: description on the same line as test_expect_success
  t7004: begin the test body on the same line as test_expect_success
  t7004: use single quotes instead of double quotes
  t7004: make use of write_script

 t/t7004-tag.sh | 1144 +++++++++++++++++++++++-------------------------
 1 file changed, 549 insertions(+), 595 deletions(-)


base-commit: 406f326d271e0bacecdb00425422c5fa3f314930
-- 
2.43.0


             reply	other threads:[~2024-08-08 16:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08 16:31 AbdAlRahman Gad [this message]
2024-08-08 16:32 ` [PATCH v6 1/8] t7004: remove space after redirect operators AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 2/8] t7004: one command per line AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 3/8] t7004: do not prepare things outside test_expect_success AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 4/8] t7004: use indented here-doc AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 5/8] t7004: description on the same line as test_expect_success AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 6/8] t7004: begin the test body " AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 7/8] t7004: use single quotes instead of double quotes AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 8/8] t7004: make use of write_script AbdAlRahman Gad
2024-08-13 19:57 ` [PATCH v6 0/8] [Newcomer] t7004: modernize the style Eric Sunshine
2024-08-13 21:58   ` AbdAlRahman Gad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240808163302.17521-1-abdobngad@gmail.com \
    --to=abdobngad@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).