From: AbdAlRahman Gad <abdobngad@gmail.com>
To: git@vger.kernel.org
Cc: AbdAlRahman Gad <abdobngad@gmail.com>
Subject: [PATCH v6 2/8] t7004: one command per line
Date: Thu, 8 Aug 2024 19:32:01 +0300 [thread overview]
Message-ID: <20240808163302.17521-3-abdobngad@gmail.com> (raw)
In-Reply-To: <20240808163302.17521-1-abdobngad@gmail.com>
One of the tests in t7004 has multiple commands on a single line,
which is discouraged. Adapt these by splitting up these into one
line per command.
Signed-off-by: AbdAlRahman Gad <abdobngad@gmail.com>
---
t/t7004-tag.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index 3100a4c219..09ce287559 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -213,9 +213,11 @@ mytag
EOF
test_expect_success \
'trying to delete tags without params should succeed and do nothing' '
- git tag -l >actual && test_cmp expect actual &&
+ git tag -l >actual &&
+ test_cmp expect actual &&
git tag -d &&
- git tag -l >actual && test_cmp expect actual
+ git tag -l >actual &&
+ test_cmp expect actual
'
test_expect_success \
--
2.43.0
next prev parent reply other threads:[~2024-08-08 16:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 16:31 [PATCH v6 0/8] [Newcomer] t7004: modernize the style AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 1/8] t7004: remove space after redirect operators AbdAlRahman Gad
2024-08-08 16:32 ` AbdAlRahman Gad [this message]
2024-08-08 16:32 ` [PATCH v6 3/8] t7004: do not prepare things outside test_expect_success AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 4/8] t7004: use indented here-doc AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 5/8] t7004: description on the same line as test_expect_success AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 6/8] t7004: begin the test body " AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 7/8] t7004: use single quotes instead of double quotes AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 8/8] t7004: make use of write_script AbdAlRahman Gad
2024-08-13 19:57 ` [PATCH v6 0/8] [Newcomer] t7004: modernize the style Eric Sunshine
2024-08-13 21:58 ` AbdAlRahman Gad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808163302.17521-3-abdobngad@gmail.com \
--to=abdobngad@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).