From: AbdAlRahman Gad <abdobngad@gmail.com>
To: git@vger.kernel.org
Cc: AbdAlRahman Gad <abdobngad@gmail.com>
Subject: [PATCH v6 4/8] t7004: use indented here-doc
Date: Thu, 8 Aug 2024 19:32:03 +0300 [thread overview]
Message-ID: <20240808163302.17521-5-abdobngad@gmail.com> (raw)
In-Reply-To: <20240808163302.17521-1-abdobngad@gmail.com>
Use <<-\EOF instead of <<\EOF where the latter allows us to indent
the body of the here-doc.
Signed-off-by: AbdAlRahman Gad <abdobngad@gmail.com>
---
t/t7004-tag.sh | 38 +++++++++++++++++++-------------------
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index a755d3be00..996020fd7c 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -387,10 +387,10 @@ test_expect_success 'tag -l <pattern> -l <pattern> works, as our buggy documenta
test_expect_success 'listing tags in column' '
COLUMNS=41 git tag -l --column=row >actual &&
- cat >expected <<\EOF &&
-a1 aa1 cba t210 t211
-v0.2.1 v1.0 v1.0.1 v1.1.3
-EOF
+ cat >expected <<-\EOF &&
+ a1 aa1 cba t210 t211
+ v0.2.1 v1.0 v1.0.1 v1.1.3
+ EOF
test_cmp expected actual
'
@@ -398,10 +398,10 @@ test_expect_success 'listing tags in column with column.*' '
test_config column.tag row &&
test_config column.ui dense &&
COLUMNS=40 git tag -l >actual &&
- cat >expected <<\EOF &&
-a1 aa1 cba t210 t211
-v0.2.1 v1.0 v1.0.1 v1.1.3
-EOF
+ cat >expected <<-\EOF &&
+ a1 aa1 cba t210 t211
+ v0.2.1 v1.0 v1.0.1 v1.1.3
+ EOF
test_cmp expected actual
'
@@ -412,17 +412,17 @@ test_expect_success 'listing tag with -n --column should fail' '
test_expect_success 'listing tags -n in column with column.ui ignored' '
test_config column.ui "row dense" &&
COLUMNS=40 git tag -l -n >actual &&
- cat >expected <<\EOF &&
-a1 Foo
-aa1 Foo
-cba Foo
-t210 Foo
-t211 Foo
-v0.2.1 Foo
-v1.0 Foo
-v1.0.1 Foo
-v1.1.3 Foo
-EOF
+ cat >expected <<-\EOF &&
+ a1 Foo
+ aa1 Foo
+ cba Foo
+ t210 Foo
+ t211 Foo
+ v0.2.1 Foo
+ v1.0 Foo
+ v1.0.1 Foo
+ v1.1.3 Foo
+ EOF
test_cmp expected actual
'
--
2.43.0
next prev parent reply other threads:[~2024-08-08 16:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 16:31 [PATCH v6 0/8] [Newcomer] t7004: modernize the style AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 1/8] t7004: remove space after redirect operators AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 2/8] t7004: one command per line AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 3/8] t7004: do not prepare things outside test_expect_success AbdAlRahman Gad
2024-08-08 16:32 ` AbdAlRahman Gad [this message]
2024-08-08 16:32 ` [PATCH v6 5/8] t7004: description on the same line as test_expect_success AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 6/8] t7004: begin the test body " AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 7/8] t7004: use single quotes instead of double quotes AbdAlRahman Gad
2024-08-08 16:32 ` [PATCH v6 8/8] t7004: make use of write_script AbdAlRahman Gad
2024-08-13 19:57 ` [PATCH v6 0/8] [Newcomer] t7004: modernize the style Eric Sunshine
2024-08-13 21:58 ` AbdAlRahman Gad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808163302.17521-5-abdobngad@gmail.com \
--to=abdobngad@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).