From: Jeff King <peff@peff.net>
To: Kim Scarborough <kim@scarborough.kim>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Subject: Re: Git and gettext
Date: Mon, 12 Aug 2024 10:48:06 -0400 [thread overview]
Message-ID: <20240812144806.GB3800004@coredump.intra.peff.net> (raw)
In-Reply-To: <97f1ca52-85b1-443d-a52c-67fce2e25f98@scarborough.kim>
On Tue, Aug 06, 2024 at 04:52:39AM -0500, Kim Scarborough wrote:
> On 8/4/24 7:53 PM, Jeff King wrote:
> > If we don't have msgfmt, I think git-gui invokes a custom script via
> > tclsh. If you also don't have that, it will fail. Running with "make
> > V=1" makes this more obvious, since it shows the fallback command name
> > instead of "MSGFMT".
> >
> > If you don't need git-gui at all, the simplest thing is to just run
> > "make NO_GETTEXT=1 NO_TCLTK=1". That's what I do, and I have neither
> > msgfmt nor gettext on my system.
>
> That did it. Thanks!
>
> Would it be possible to modify the configure script so that it checks for
> this stuff?
Probably. It looks like the configure script knows about both gettext
and tcl paths, but running "autoconf && ./configure" on my machine
doesn't disable either.
Looks like the NO_GETTEXT test is checking to compile against libintl.
Which I do have (it comes with glibc), but I don't have the other tools.
For tcl, you can say "--without-tcltk" manually. But if you don't, it
just assumes "wish" is present without checking.
So I'd imagine that both tests could be made more robust. I don't use
autoconf myself (in the Git project, it is an optional layer that sits
on top of the Makefile knobs), so I'll leave that to somebody more
motivated (and hopefully more familiar with the usual autoconf solutions
to these kinds of things).
-Peff
prev parent reply other threads:[~2024-08-12 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-03 7:58 Git and gettext Kim Scarborough
2024-08-03 16:00 ` brian m. carlson
2024-08-03 17:24 ` Kim Scarborough
2024-08-03 17:34 ` brian m. carlson
2024-08-04 21:26 ` Kim Scarborough
2024-08-05 0:53 ` Jeff King
2024-08-06 9:52 ` Kim Scarborough
2024-08-12 14:48 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812144806.GB3800004@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kim@scarborough.kim \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox