git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chandra Pratap <chandrapratap3519@gmail.com>
To: git@vger.kernel.org
Cc: Chandra Pratap <chandrapratap3519@gmail.com>,
	Patrick Steinhardt <ps@pks.im>,
	Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH 02/10] t-reftable-block: release used block reader
Date: Wed, 14 Aug 2024 17:33:10 +0530	[thread overview]
Message-ID: <20240814121122.4642-3-chandrapratap3519@gmail.com> (raw)
In-Reply-To: <20240814121122.4642-1-chandrapratap3519@gmail.com>

Used block readers must be released using block_reader_release() to
prevent the occurence of a memory leak. Make test_block_read_write()
conform to this statement.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
---
 t/unit-tests/t-reftable-block.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/t/unit-tests/t-reftable-block.c b/t/unit-tests/t-reftable-block.c
index 8ab3ff9ebe..31d179a50a 100644
--- a/t/unit-tests/t-reftable-block.c
+++ b/t/unit-tests/t-reftable-block.c
@@ -103,6 +103,7 @@ static void t_block_read_write(void)
 		block_iter_close(&it);
 	}
 
+	block_reader_release(&br);
 	reftable_record_release(&rec);
 	reftable_block_done(&br.block);
 	strbuf_release(&want);
-- 
2.45.GIT


  parent reply	other threads:[~2024-08-14 12:12 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 12:03 [GSoC][PATCH 00/10] t: port reftable/block_test.c to the unit testing framework Chandra Pratap
2024-08-14 12:03 ` [PATCH 01/10] t: move " Chandra Pratap
2024-08-14 12:03 ` Chandra Pratap [this message]
2024-08-15  9:40   ` [PATCH 02/10] t-reftable-block: release used block reader Patrick Steinhardt
2024-08-15 18:22     ` Chandra Pratap
2024-08-14 12:03 ` [PATCH 03/10] t-reftable-block: use reftable_record_equal() instead of check_str() Chandra Pratap
2024-08-15  9:40   ` Patrick Steinhardt
2024-08-14 12:03 ` [PATCH 04/10] t-reftable-block: use reftable_record_key() instead of strbuf_addstr() Chandra Pratap
2024-08-15  9:40   ` Patrick Steinhardt
2024-08-14 12:03 ` [PATCH 05/10] t-reftable-block: use block_iter_reset() instead of block_iter_close() Chandra Pratap
2024-08-15  9:40   ` Patrick Steinhardt
2024-08-14 12:03 ` [PATCH 06/10] t-reftable-block: use xstrfmt() instead of xstrdup() Chandra Pratap
2024-08-14 12:03 ` [PATCH 07/10] t-reftable-block: remove unnecessary variable 'j' Chandra Pratap
2024-08-14 12:03 ` [PATCH 08/10] t-reftable-block: add tests for log blocks Chandra Pratap
2024-08-15  9:41   ` Patrick Steinhardt
2024-08-15 18:36     ` Chandra Pratap
2024-08-16  7:42       ` Patrick Steinhardt
2024-08-14 12:03 ` [PATCH 09/10] t-reftable-block: add tests for obj blocks Chandra Pratap
2024-08-15  9:41   ` Patrick Steinhardt
2024-08-15 19:11     ` Chandra Pratap
2024-08-16  7:44       ` Patrick Steinhardt
2024-08-14 12:03 ` [PATCH 10/10] t-reftable-block: add tests for index blocks Chandra Pratap
2024-08-15  9:41   ` Patrick Steinhardt
2024-08-16 17:25 ` [GSoC][PATCH v2 00/11] t: port reftable/block_test.c to the unit testing framework Chandra Pratap
2024-08-16 17:25   ` [PATCH v2 01/11] t: move " Chandra Pratap
2024-08-16 17:25   ` [PATCH v2 02/11] t: harmonize t-reftable-block.c with coding guidelines Chandra Pratap
2024-08-16 17:25   ` [PATCH v2 03/11] t-reftable-block: release used block reader Chandra Pratap
2024-08-16 17:25   ` [PATCH v2 04/11] t-reftable-block: use reftable_record_equal() instead of check_str() Chandra Pratap
2024-08-16 17:25   ` [PATCH v2 05/11] t-reftable-block: use reftable_record_key() instead of strbuf_addstr() Chandra Pratap
2024-08-16 17:25   ` [PATCH v2 06/11] t-reftable-block: use block_iter_reset() instead of block_iter_close() Chandra Pratap
2024-08-16 17:25   ` [PATCH v2 07/11] t-reftable-block: use xstrfmt() instead of xstrdup() Chandra Pratap
2024-08-16 17:25   ` [PATCH v2 08/11] t-reftable-block: remove unnecessary variable 'j' Chandra Pratap
2024-08-16 17:25   ` [PATCH v2 09/11] t-reftable-block: add tests for log blocks Chandra Pratap
2024-08-21  7:28     ` Patrick Steinhardt
2024-08-21 16:13       ` Junio C Hamano
2024-08-16 17:25   ` [PATCH v2 10/11] t-reftable-block: add tests for obj blocks Chandra Pratap
2024-08-16 18:11     ` Chandra Pratap
2024-08-16 17:25   ` [PATCH v2 11/11] t-reftable-block: add tests for index blocks Chandra Pratap
2024-08-21  7:30   ` [GSoC][PATCH v2 00/11] t: port reftable/block_test.c to the unit testing framework Chandra Pratap
2024-08-21 12:30   ` [GSoC][PATCH v3 " Chandra Pratap
2024-08-21 12:30     ` [PATCH v3 01/11] t: move " Chandra Pratap
2024-08-21 12:30     ` [PATCH v3 02/11] t: harmonize t-reftable-block.c with coding guidelines Chandra Pratap
2024-08-21 12:30     ` [PATCH v3 03/11] t-reftable-block: release used block reader Chandra Pratap
2024-08-21 12:30     ` [PATCH v3 04/11] t-reftable-block: use reftable_record_equal() instead of check_str() Chandra Pratap
2024-08-21 12:30     ` [PATCH v3 05/11] t-reftable-block: use reftable_record_key() instead of strbuf_addstr() Chandra Pratap
2024-08-21 12:30     ` [PATCH v3 06/11] t-reftable-block: use block_iter_reset() instead of block_iter_close() Chandra Pratap
2024-08-21 12:30     ` [PATCH v3 07/11] t-reftable-block: use xstrfmt() instead of xstrdup() Chandra Pratap
2024-08-21 12:30     ` [PATCH v3 08/11] t-reftable-block: remove unnecessary variable 'j' Chandra Pratap
2024-08-21 12:30     ` [PATCH v3 09/11] t-reftable-block: add tests for log blocks Chandra Pratap
2024-08-21 12:31     ` [PATCH v3 10/11] t-reftable-block: add tests for obj blocks Chandra Pratap
2024-08-21 12:31     ` [PATCH v3 11/11] t-reftable-block: add tests for index blocks Chandra Pratap
2024-08-22  6:39     ` [GSoC][PATCH v3 00/11] t: port reftable/block_test.c to the unit testing framework Patrick Steinhardt
2024-08-22 18:01       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814121122.4642-3-chandrapratap3519@gmail.com \
    --to=chandrapratap3519@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).