git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Cc: Jacob Keller <jacob.keller@gmail.com>
Subject: [PATCH 3/3] fixup! send-email: teach git send-email option to translate aliases
Date: Thu, 15 Aug 2024 16:49:24 -0700	[thread overview]
Message-ID: <20240815234924.3963696-1-jacob.e.keller@intel.com> (raw)

From: Jacob Keller <jacob.keller@gmail.com>

Two of the tests added for --translate-aliases did not set the
prerequisites, so systems which build without perl support will fail the
tests. Fix this.

Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
---
 t/t9001-send-email.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 13f1453eebb9..c5e862694e16 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -2202,7 +2202,7 @@ test_translate_aliases '--translate-aliases gnus format' \
 	(define-mail-alias "chloe" "chloe@example.com")
 	EOF
 
-test_expect_success '--translate-aliases passes valid addresses through' '
+test_expect_success $PREREQ '--translate-aliases passes valid addresses through' '
 	cat >expect <<-\EOF &&
 	Other <o@example.com>
 	EOF
@@ -2213,7 +2213,7 @@ test_expect_success '--translate-aliases passes valid addresses through' '
 	test_cmp expect actual
 '
 
-test_expect_success '--translate-aliases passes unknown aliases through' '
+test_expect_success $PREREQ '--translate-aliases passes unknown aliases through' '
 	cat >expect <<-\EOF &&
 	blargh
 	EOF
-- 
2.46.0.124.g2dc1a81c8933


                 reply	other threads:[~2024-08-15 23:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240815234924.3963696-1-jacob.e.keller@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jacob.keller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).