git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: Josh Steadmon <steadmon@google.com>,
	git@vger.kernel.org,  Junio C Hamano <gitster@pobox.com>,
	Jeff King <peff@peff.net>
Subject: [PATCH 0/2] send-email: add --mailmap support
Date: Fri, 16 Aug 2024 16:06:22 -0700	[thread overview]
Message-ID: <20240816-jk-send-email-mailmap-support-v1-0-68ca5b4a6078@gmail.com> (raw)

I recently sent a series to enable mailmap support in format patch. The
discussion led me to realize that the true problem we wanted solved is to
map addresses at send time, so that we do not accidentally include a dead
mail address when sending an old change.

Instead of worrying about what the formatted patch has, this series
implements support for mailmap at the send-email, which will translate all
addresses, and not just the author/commit addresses for a patch, but also
the email for any trailers.o

I considered also that it may be useful to make send-email read a mailmap
file from the identity config blocks, but have not figured out how to
implement this yet.

I ended up needing to extend git check-mailmap to handle addresses without
the angle brackets as well.

I think this is closer to solving the actual problem we have, which is
wanting to avoid adding dead email addresses for coworkers who have moved
on, but without completely removing their name from the works.

Link to previous: https://lore.kernel.org/r/20240813-jk-support-mailmap-git-format-patch-v1-1-1aea690ea5dd@gmail.com

Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
---
Jacob Keller (2):
      check-mailmap: add --no-brackets mode
      send-email: add support for --mailmap

 builtin/check-mailmap.c             | 27 ++++++++++++-----
 Documentation/git-check-mailmap.txt |  8 ++++-
 git-send-email.perl                 | 14 +++++++++
 t/t4203-mailmap.sh                  | 60 +++++++++++++++++++++++++++++++++++++
 t/t9001-send-email.sh               | 49 ++++++++++++++++++++++++++++++
 5 files changed, 149 insertions(+), 9 deletions(-)
---
base-commit: 87a1768b93a67d0420255a43d9e07387b2e805ad
change-id: 20240816-jk-send-email-mailmap-support-1a9e86867c72

Best regards,
-- 
Jacob Keller <jacob.keller@gmail.com>


             reply	other threads:[~2024-08-16 23:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16 23:06 Jacob Keller [this message]
2024-08-16 23:06 ` [PATCH 1/2] check-mailmap: add --no-brackets mode Jacob Keller
2024-08-16 23:22   ` Eric Sunshine
2024-08-16 23:42     ` Jacob Keller
2024-08-16 23:51       ` Eric Sunshine
2024-08-16 23:06 ` [PATCH 2/2] send-email: add support for --mailmap Jacob Keller
2024-08-16 23:41   ` Eric Sunshine
2024-08-16 23:49     ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240816-jk-send-email-mailmap-support-v1-0-68ca5b4a6078@gmail.com \
    --to=jacob.e.keller@intel.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=steadmon@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).