From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH] reftable: mark unused parameters in empty iterator functions
Date: Wed, 28 Aug 2024 00:09:44 -0400 [thread overview]
Message-ID: <20240828040944.GA4005021@coredump.intra.peff.net> (raw)
These unused parameters were marked in a68ec8683a (reftable: mark unused
parameters in virtual functions, 2024-08-17), but the functions were
moved to a new file in a parallel branch via f2406c81b9
(reftable/generic: move generic iterator code into iterator interface,
2024-08-22).
Signed-off-by: Jeff King <peff@peff.net>
---
This should go on top of ps/reftable-drop-generic. Arguably this could
have been done as part of the conflict resolution when merging into next
alongside jk/mark-unused-parameters, but at this point I think a
separate patch is the best way forward.
reftable/iter.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/reftable/iter.c b/reftable/iter.c
index 97a4642ed5..1d99fe4f7d 100644
--- a/reftable/iter.c
+++ b/reftable/iter.c
@@ -25,17 +25,17 @@ int iterator_next(struct reftable_iterator *it, struct reftable_record *rec)
return it->ops->next(it->iter_arg, rec);
}
-static int empty_iterator_seek(void *arg, struct reftable_record *want)
+static int empty_iterator_seek(void *arg UNUSED, struct reftable_record *want UNUSED)
{
return 0;
}
-static int empty_iterator_next(void *arg, struct reftable_record *rec)
+static int empty_iterator_next(void *arg UNUSED, struct reftable_record *rec UNUSED)
{
return 1;
}
-static void empty_iterator_close(void *arg)
+static void empty_iterator_close(void *arg UNUSED)
{
}
--
2.46.0.754.g24c813f009
next reply other threads:[~2024-08-28 4:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 4:09 Jeff King [this message]
2024-08-28 8:19 ` [PATCH] reftable: mark unused parameters in empty iterator functions Patrick Steinhardt
2024-08-28 17:12 ` Junio C Hamano
2024-08-28 18:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828040944.GA4005021@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).