From: Jeff King <peff@peff.net>
To: Brooke Kuhlmann <brooke@alchemists.io>
Cc: git@vger.kernel.org
Subject: Re: Fix issue with formatting multiple trailer keys
Date: Mon, 9 Sep 2024 19:03:31 -0400 [thread overview]
Message-ID: <20240909230331.GA921644@coredump.intra.peff.net> (raw)
In-Reply-To: <5A3FD50B-46F1-4000-8AAD-895A4CB4F33F@alchemists.io>
On Fri, Sep 06, 2024 at 05:09:08PM -0600, Brooke Kuhlmann wrote:
> Use of a custom separator is a nifty trick. Thanks. A little
> unintuitive but works. Definitely would be neat if you patch this to
> work without the custom separator, though.
The separator will always be required (even if you use multiple
%(trailer) blocks), because it overrides the default of terminating with
a newline. And we can't switch that default without breaking
compatibility for existing users.
So I think after my series you'll have:
%(trailers:key=Files,separator=) %(trailers:key=Duration,separator=)
or similar.
-Peff
next prev parent reply other threads:[~2024-09-09 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 19:55 Fix issue with formatting multiple trailer keys Brooke Kuhlmann
2024-09-06 22:34 ` Jeff King
2024-09-06 23:09 ` Brooke Kuhlmann
2024-09-09 23:03 ` Jeff King [this message]
2024-09-10 2:22 ` Brooke Kuhlmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909230331.GA921644@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=brooke@alchemists.io \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox