From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Brooke Kuhlmann <brooke@alchemists.io>
Subject: [PATCH 0/9] ref-filter %(trailer) fixes
Date: Mon, 9 Sep 2024 19:07:58 -0400 [thread overview]
Message-ID: <20240909230758.GA921697@coredump.intra.peff.net> (raw)
This series fixes two bugs noticed by Brooke:
- parsing trailers from signed tags doesn't work, because the
signature confuses the trailers code
- multiple %(trailers) placeholders share some storage, so their
options may conflict
The fixes for those are in patches 3 and 5, respectively. The other
patches up to there are related cleanups and preparation.
When fixing the second one, I noticed an obvious memory leak, fixed in
patch 6. And then that made me wonder if that made t6300 leak-free. It
didn't, but patches 7-9 get it there.
So 6-9 could be taken as a separate series, but they do textually depend
on what came before.
[1/9]: t6300: drop newline from wrapped test title
[2/9]: ref-filter: avoid extra copies of payload/signature
[3/9]: ref-filter: strip signature when parsing tag trailers
[4/9]: ref-filter: drop useless cast in trailers_atom_parser()
[5/9]: ref-filter: store ref_trailer_buf data per-atom
[6/9]: ref-filter: fix leak of %(trailers) "argbuf"
[7/9]: ref-filter: fix leak with %(describe) arguments
[8/9]: ref-filter: fix leak when formatting %(push:remoteref)
[9/9]: ref-filter: add ref_format_clear() function
builtin/branch.c | 1 +
builtin/for-each-ref.c | 1 +
builtin/tag.c | 1 +
builtin/verify-tag.c | 1 +
ref-filter.c | 90 ++++++++++++++++++++++++++++++-----------
ref-filter.h | 3 ++
remote.c | 8 ++--
remote.h | 2 +-
t/t6300-for-each-ref.sh | 41 ++++++++++++++++++-
9 files changed, 118 insertions(+), 30 deletions(-)
-Peff
next reply other threads:[~2024-09-09 23:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 23:07 Jeff King [this message]
2024-09-09 23:08 ` [PATCH 1/9] t6300: drop newline from wrapped test title Jeff King
2024-09-09 23:12 ` [PATCH 2/9] ref-filter: avoid extra copies of payload/signature Jeff King
2024-09-10 6:09 ` Patrick Steinhardt
2024-09-10 6:26 ` Jeff King
2024-09-09 23:14 ` [PATCH 3/9] ref-filter: strip signature when parsing tag trailers Jeff King
2024-09-10 6:08 ` Patrick Steinhardt
2024-09-10 6:28 ` Jeff King
2024-09-09 23:14 ` [PATCH 4/9] ref-filter: drop useless cast in trailers_atom_parser() Jeff King
2024-09-09 23:16 ` [PATCH 5/9] ref-filter: store ref_trailer_buf data per-atom Jeff King
2024-09-10 6:08 ` Patrick Steinhardt
2024-09-09 23:18 ` [PATCH 6/9] ref-filter: fix leak of %(trailers) "argbuf" Jeff King
2024-09-10 6:09 ` Patrick Steinhardt
2024-09-10 6:33 ` Jeff King
2024-09-09 23:19 ` [PATCH 7/9] ref-filter: fix leak with %(describe) arguments Jeff King
2024-09-09 23:19 ` [PATCH 8/9] ref-filter: fix leak when formatting %(push:remoteref) Jeff King
2024-09-10 6:09 ` Patrick Steinhardt
2024-09-09 23:21 ` [PATCH 9/9] ref-filter: add ref_format_clear() function Jeff King
2024-09-10 6:09 ` Patrick Steinhardt
2024-09-10 6:37 ` Jeff King
2024-09-10 6:57 ` [PATCH 10/9] ref-filter: fix leak with unterminated %(if) atoms Patrick Steinhardt
2024-09-10 7:12 ` Jeff King
2024-09-10 16:48 ` Junio C Hamano
2024-09-12 10:22 ` Patrick Steinhardt
2024-09-12 11:18 ` Jeff King
2024-09-12 11:32 ` Patrick Steinhardt
2024-09-12 20:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909230758.GA921697@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=brooke@alchemists.io \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).