git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] ci: remove 'Upload failed tests' directories' step from linux32 jobs
Date: Thu, 12 Sep 2024 04:00:11 -0400	[thread overview]
Message-ID: <20240912080011.GA556677@coredump.intra.peff.net> (raw)
In-Reply-To: <20240912075631.GA11676@coredump.intra.peff.net>

On Thu, Sep 12, 2024 at 03:56:32AM -0400, Jeff King wrote:

> > If somebody finds a better solution (i.e., a way to extract trash
> > directories of failed tests', with actions/upload-artifact@v1), that
> > can be added later on top.
> 
> I looked at this a bit last night, but as I didn't come up with any
> useful solution, I refrained from replying. I was going to do a brief
> write-up of all of my dead ends, but after banging my head against the
> wall a bit more, I think I might actually have something. ;)
> 
> I think a better path forward is to figure out how to keep up to date
> with the upload-artifact action for all jobs. The root of the issue is
> that all of the runner images are 64-bit, and the actions aren't
> prepared to run inside a 32-bit container. They're written in javascript
> and ship with their own node.js, but it doesn't work inside the
> container due to dynamic linking issues.

So obviously that other email ended up long and full of details. What I
was originally going to say was: "OK, losing artifact uploads for
linux32 is not the end of the world, and it is important to unblock CI
now."

But I _think_ all of those details I sent add up to a possible patch
series. But it probably still makes sense to take your patch here, as it
unblocks CI in the short term. And then I can build the bigger fix on
top of that (it touches the same spot, but in the end both end up
removing that special case).

-Peff

  reply	other threads:[~2024-09-12  8:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 23:00 [PATCH] ci: remove 'Upload failed tests' directories' step from linux32 jobs Junio C Hamano
2024-09-11 22:32 ` Junio C Hamano
2024-09-12  7:56   ` Jeff King
2024-09-12  8:00     ` Jeff King [this message]
2024-09-12  9:42       ` [PATCH 0/4] make linux32 ci job work with recent actions Jeff King
2024-09-12  9:43         ` [PATCH 1/4] ci: drop run-docker scripts Jeff King
2024-09-12 10:40           ` Patrick Steinhardt
2024-09-12  9:45         ` [PATCH 2/4] ci: unify ubuntu and ubuntu32 dependencies Jeff King
2024-09-12 10:41           ` Patrick Steinhardt
2024-09-12  9:47         ` [PATCH 3/4] ci: use more recent linux32 image Jeff King
2024-09-12 10:41           ` Patrick Steinhardt
2024-09-12 11:22             ` Jeff King
2024-09-12 11:53               ` Patrick Steinhardt
2024-09-12 12:47                 ` Patrick Steinhardt
2024-09-13  4:55                   ` Jeff King
2024-09-13  5:39                     ` Patrick Steinhardt
2024-09-12  9:48         ` [PATCH 4/4] ci: use regular action versions for linux32 job Jeff King
2024-09-12 19:41         ` [PATCH 0/4] make linux32 ci job work with recent actions Junio C Hamano
2024-09-13  5:52         ` [PATCH 5/4] ci: add Ubuntu 16.04 job to GitLab CI Patrick Steinhardt
2024-09-13  6:21           ` Jeff King
2024-09-13  6:39             ` Patrick Steinhardt
2024-09-13  6:43               ` Jeff King
2024-09-13  6:47                 ` Patrick Steinhardt
2024-09-13 16:17             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240912080011.GA556677@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).