From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] ci(linux32): make Javascript Actions work in x86 mode
Date: Sun, 15 Sep 2024 07:07:06 -0400 [thread overview]
Message-ID: <20240915110706.GA2017642@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq34m2tasj.fsf@gitster.g>
On Sat, Sep 14, 2024 at 10:17:16AM -0700, Junio C Hamano wrote:
> Each of these approaches may have its pros and cons, but I somehow
> do not see that the newly proposed alternative is 10x better than
> what was reviewed and queued already to be worth the effort to
> replace it.
That's my feeling, too, but I'd reserve final judgement to see Dscho's
response; it's possible I am under-estimating the 32/64-bit confusion
risk.
I'd also note that his patch does not require bumping the distro
version, which would let us continue testing that old version in GitHub
Actions. That might be worth considering.
-Peff
next prev parent reply other threads:[~2024-09-15 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 0:42 [PATCH] ci(linux32): make Javascript Actions work in x86 mode Johannes Schindelin via GitGitGadget
2024-09-14 7:29 ` Jeff King
2024-09-14 17:17 ` Junio C Hamano
2024-09-15 11:07 ` Jeff King [this message]
2024-09-15 16:25 ` Junio C Hamano
2024-09-17 12:20 ` Johannes Schindelin
2024-09-17 15:01 ` Junio C Hamano
2024-09-19 7:05 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240915110706.GA2017642@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox