From: Josh Heinrichs <joshiheinrichs@gmail.com>
To: git@vger.kernel.org
Cc: Josh Heinrichs <joshiheinrichs@gmail.com>
Subject: [PATCH v2 0/1] Remove value from position args in config unset usage
Date: Tue, 8 Oct 2024 08:29:19 -0600 [thread overview]
Message-ID: <20241008142920.570244-1-joshiheinrichs@gmail.com> (raw)
In-Reply-To: <20241008040749.69801-1-joshiheinrichs@gmail.com>
Hello!
This version addresses the issues with my commit message that Patrick flagged
in v1.
Josh
Josh Heinrichs (1):
git-config.1: remove value from positional args in unset usage
Documentation/git-config.txt | 2 +-
builtin/config.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
Range-diff against v1:
1: 4bb9c65fb9 ! 1: e3b5f3c8b2 git-config.1: remove value from positional args in unset usage
@@ Metadata
## Commit message ##
git-config.1: remove value from positional args in unset usage
- A single positional argument appears to be enforcecd at
- builtin/config.c:993. Values need to be provided via --value.
+ The synopsis for `git config unset` mentions two positional arguments:
+ `<name>` and `<value>`. While the first argument is correct, the second
+ is not. Users are expected to provide the value via `--value=<value>`.
+
+ Remove the positional argument. The `--value=<value>` option is already
+ documented correctly, so this is all we need to do to fix the
+ documentation.
+
+ Signed-off-by: Josh Heinrichs <joshiheinrichs@gmail.com>
## Documentation/git-config.txt ##
@@ Documentation/git-config.txt: SYNOPSIS
--
2.25.1
next prev parent reply other threads:[~2024-10-08 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 4:07 [PATCH 0/1] Remove value from positional args in config unset usage Josh Heinrichs
2024-10-08 4:07 ` [PATCH 1/1] git-config.1: remove value from positional args in " Josh Heinrichs
2024-10-08 12:37 ` Patrick Steinhardt
2024-10-08 14:29 ` Josh Heinrichs [this message]
2024-10-08 14:29 ` [PATCH v2 " Josh Heinrichs
2024-10-08 18:20 ` Junio C Hamano
2024-10-09 3:37 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008142920.570244-1-joshiheinrichs@gmail.com \
--to=joshiheinrichs@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).