* [PATCH] t4205: fix typo in 'NUL termination with --stat'
@ 2024-10-20 19:18 Kousik Sanagavarapu
2024-10-21 21:36 ` Taylor Blau
0 siblings, 1 reply; 2+ messages in thread
From: Kousik Sanagavarapu @ 2024-10-20 19:18 UTC (permalink / raw)
To: git; +Cc: Kousik Sanagavarapu
Correct "expected" to rightly terminate with NUL ie '\0' instead of '0'
which may have been typoed.
We didn't notice this before because the test is run with
"test_expect_failure", meaning the test would have been marked broken
anyways.
Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
---
t/t4205-log-pretty-formats.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh
index eb63ce011f..57b8b79738 100755
--- a/t/t4205-log-pretty-formats.sh
+++ b/t/t4205-log-pretty-formats.sh
@@ -137,7 +137,7 @@ test_expect_success 'NUL separation with --stat' '
test_expect_failure 'NUL termination with --stat' '
stat0_part=$(git diff --stat HEAD^ HEAD) &&
stat1_part=$(git diff-tree --no-commit-id --stat --root HEAD^) &&
- printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n0" >expected &&
+ printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n\0" >expected &&
git log -z --stat --pretty="tformat:%s" >actual &&
test_cmp expected actual
'
--
2.47.0.107.g34b6ce9b30
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t4205: fix typo in 'NUL termination with --stat'
2024-10-20 19:18 [PATCH] t4205: fix typo in 'NUL termination with --stat' Kousik Sanagavarapu
@ 2024-10-21 21:36 ` Taylor Blau
0 siblings, 0 replies; 2+ messages in thread
From: Taylor Blau @ 2024-10-21 21:36 UTC (permalink / raw)
To: Kousik Sanagavarapu; +Cc: git
On Mon, Oct 21, 2024 at 12:48:47AM +0530, Kousik Sanagavarapu wrote:
> t/t4205-log-pretty-formats.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for finding and fixing. Let's merge this one down.
Thanks,
Taylor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-21 21:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-20 19:18 [PATCH] t4205: fix typo in 'NUL termination with --stat' Kousik Sanagavarapu
2024-10-21 21:36 ` Taylor Blau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).