git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Abhijeet Sonar <abhijeet.nkt@gmail.com>
To: gitster@pobox.com
Cc: abhijeet.nkt@gmail.com, git@vger.kernel.org, me@ttaylorr.com,
	ps@pks.im, sandals@crustytoothpaste.net
Subject: [PATCH v6 2/2] t5300: add test for 'show-index --object-format'
Date: Sat,  9 Nov 2024 14:57:39 +0530	[thread overview]
Message-ID: <20241109092739.14276-3-abhijeet.nkt@gmail.com> (raw)
In-Reply-To: <20241109092739.14276-1-abhijeet.nkt@gmail.com>

In 88a09a557c (builtin/show-index: provide options to determine hash
algo), the flag --object-format was added to show-index builtin as a way
to provide a hash algorithm explicitly. However, we do not have tests in
place for that functionality. Add them.

Signed-off-by: Abhijeet Sonar <abhijeet.nkt@gmail.com>
---
 t/t5300-pack-object.sh | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh
index 51fed26cc4..bb6a22b438 100755
--- a/t/t5300-pack-object.sh
+++ b/t/t5300-pack-object.sh
@@ -527,6 +527,20 @@ test_expect_success SHA1 'show-index works OK outside a repository' '
 	nongit git show-index <foo.idx
 '
 
+for hash in sha1 sha256
+do
+	test_expect_success 'show-index works OK outside a repository with hash algo passed in via --object-format' '
+		test_when_finished "rm -rf explicit-hash-$hash" &&
+		git init --object-format=$hash explicit-hash-$hash &&
+		test_commit -C explicit-hash-$hash one &&
+		git -C explicit-hash-$hash rev-parse one >in &&
+		git -C explicit-hash-$hash pack-objects explicit-hash-$hash <in &&
+		idx=$(echo explicit-hash-$hash/explicit-hash-$hash*.idx) &&
+		nongit git show-index --object-format=$hash <"$idx" >actual &&
+		test_line_count = 1 actual
+	'
+done
+
 test_expect_success !PTHREADS,!FAIL_PREREQS \
 	'index-pack --threads=N or pack.threads=N warns when no pthreads' '
 	test_must_fail git index-pack --threads=2 2>err &&
-- 
2.47.0.107.g34b6ce9b30


  parent reply	other threads:[~2024-11-09  9:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 14:23 [PATCH] show-index: fix uninitialized hash function Abhijeet Sonar
2024-07-12 15:35 ` Junio C Hamano
2024-07-15 10:23   ` [PATCH v2] " Abhijeet Sonar
2024-07-15 16:22     ` Re* " Junio C Hamano
2024-10-26 12:09       ` [PATCH v3] " Abhijeet Sonar
2024-10-28  0:10         ` Taylor Blau
2024-10-28  5:35           ` Patrick Steinhardt
2024-10-28 17:42             ` Taylor Blau
2024-11-01 17:28               ` [PATCH v4] " Abhijeet Sonar
2024-11-02 10:29                 ` Junio C Hamano
2024-11-02 16:26                   ` Abhijeet Sonar
2024-11-04 19:29                   ` [PATCH v5 0/2] " Abhijeet Sonar
2024-11-04 19:29                     ` [PATCH v5 1/2] " Abhijeet Sonar
2024-11-04 19:29                     ` [PATCH v5 2/2] t5300: add test for 'show-index --object-format' Abhijeet Sonar
2024-11-05  1:19                       ` Junio C Hamano
2024-11-09  9:27                         ` [PATCH v6 0/2] show-index: fix uninitialized hash function Abhijeet Sonar
2024-11-09  9:27                           ` [PATCH v6 1/2] " Abhijeet Sonar
2024-11-09  9:27                           ` Abhijeet Sonar [this message]
2024-11-11  3:16                           ` [PATCH v6 0/2] " Junio C Hamano
2024-12-16  8:11                           ` Patrick Steinhardt
2024-12-16 16:21                             ` Junio C Hamano
2024-10-29 11:54             ` [PATCH v3] " Abhijeet Sonar
2024-10-29 10:30           ` Abhijeet Sonar
2024-10-26 12:17       ` Re* [PATCH v2] " Abhijeet Sonar
2024-07-15 22:07     ` brian m. carlson
2024-07-15 10:31   ` [PATCH] " Abhijeet Sonar
2024-07-12 16:53 ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241109092739.14276-3-abhijeet.nkt@gmail.com \
    --to=abhijeet.nkt@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).