git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Justin Tobler <jltobler@gmail.com>
To: git@vger.kernel.org
Cc: Justin Tobler <jltobler@gmail.com>
Subject: [PATCH v2 0/4] propagate fsck message severity for bundle fetch
Date: Tue, 26 Nov 2024 18:57:03 -0600	[thread overview]
Message-ID: <20241127005707.319881-1-jltobler@gmail.com> (raw)
In-Reply-To: <20241121204119.1440773-1-jltobler@gmail.com>

Greetings,

With 63d903ff52 (unbundle: extend object verification for fetches,
2024-06-19), fsck checks are now performed on fetched bundles depending
on `transfer.fsckObjects` and `fetch.fsckObjects` configuration. This
works, but provides no means to override the default fsck message
severity as is done for other git-fetch(1) operations. This series aims
to propagate fsck message severity configuration to the underlying
git-index-pack(1) process executed on the bundle in a similar manner as
done with git-fetch-pack(1).

  - Patches 1 and 2 adapt the bundle subsystem to support additional
    options when performing `unbundle()`.

  - Patch 3 adapts the fetch-pack subsystem to expose a means to
    generate the message configuration arguments.

  - Patch 4 wires the newly generated fsck configuration options to the
    bundle options used when fetching from a bundle.

Changes in V2:

  - Reverted unnecessary line formatted changes.

  - Simplified fallback logic for default `unbundle()` options.

  - Dropped unncessary shell structure in the third patch to keep the
    patch more straightforward.

  - Instead of exposing `fetch_pack_config_cb()` directly, the fetch
    pack fsck config parsing logic is split and exposed. This also
    addresses the issue of unwanted default Git config parsing occuring.
    Consequently the previous third and fourth patch were condensed into
    a single patch.

  - Improved explainations in the patches, naming, and various style
    fixes.

Due to all rearranging in this version, I opted not to include a
range-diff.

Thanks
-Justin

Justin Tobler (4):
  bundle: add bundle verification options type
  bundle: support fsck message configuration
  fetch-pack: split out fsck config parsing
  transport: propagate fsck configuration during bundle fetch

 builtin/bundle.c        |  2 +-
 bundle-uri.c            |  7 +++++--
 bundle.c                | 13 +++++++++----
 bundle.h                | 17 ++++++++++++++---
 fetch-pack.c            | 24 +++++++++++++++++-------
 fetch-pack.h            |  3 +++
 t/t5607-clone-bundle.sh |  7 +++++++
 transport.c             | 26 ++++++++++++++++++++++++--
 8 files changed, 80 insertions(+), 19 deletions(-)


base-commit: 4083a6f05206077a50af7658bedc17a94c54607d
-- 
2.47.0


  parent reply	other threads:[~2024-11-27  0:59 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-21 20:41 [PATCH 0/5] propagate fsck message severity for bundle fetch Justin Tobler
2024-11-21 20:41 ` [PATCH 1/5] bundle: add bundle verification options type Justin Tobler
2024-11-22  1:21   ` Junio C Hamano
2024-11-22 15:22     ` Justin Tobler
2024-11-26  9:08   ` Patrick Steinhardt
2024-11-26 15:59     ` Justin Tobler
2024-11-21 20:41 ` [PATCH 2/5] bundle: support fsck message configuration Justin Tobler
2024-11-22  1:30   ` Junio C Hamano
2024-11-22 15:44     ` Justin Tobler
2024-11-25  1:33       ` Junio C Hamano
2024-11-21 20:41 ` [PATCH 3/5] fetch-pack: introduce `fetch_pack_options` Justin Tobler
2024-11-22  1:46   ` Junio C Hamano
2024-11-22  3:46     ` Junio C Hamano
2024-11-22 17:31     ` Justin Tobler
2024-11-21 20:41 ` [PATCH 4/5] fetch-pack: expose `fetch_pack_config_cb()` Justin Tobler
2024-11-22  1:57   ` Junio C Hamano
2024-11-22 17:41     ` Justin Tobler
2024-11-22 16:45   ` shejialuo
2024-11-27  1:21     ` Justin Tobler
2024-11-21 20:41 ` [PATCH 5/5] transport: propagate fsck configuration during bundle fetch Justin Tobler
2024-11-22  1:59   ` Junio C Hamano
2024-11-27  0:57 ` Justin Tobler [this message]
2024-11-27  0:57   ` [PATCH v2 1/4] bundle: add bundle verification options type Justin Tobler
2024-11-27  0:57   ` [PATCH v2 2/4] bundle: support fsck message configuration Justin Tobler
2024-11-27  5:44     ` Patrick Steinhardt
2024-11-27  0:57   ` [PATCH v2 3/4] fetch-pack: split out fsck config parsing Justin Tobler
2024-11-27  5:44     ` Patrick Steinhardt
2024-11-27 17:37       ` Justin Tobler
2024-11-27  0:57   ` [PATCH v2 4/4] transport: propagate fsck configuration during bundle fetch Justin Tobler
2024-11-27  1:39     ` Junio C Hamano
2024-11-27 23:33   ` [PATCH v3 0/4] propagate fsck message severity for " Justin Tobler
2024-11-27 23:33     ` [PATCH v3 1/4] bundle: add bundle verification options type Justin Tobler
2024-11-27 23:33     ` [PATCH v3 2/4] bundle: support fsck message configuration Justin Tobler
2024-11-27 23:33     ` [PATCH v3 3/4] fetch-pack: split out fsck config parsing Justin Tobler
2024-11-28  3:25       ` Junio C Hamano
2024-12-03  9:34         ` Patrick Steinhardt
2024-12-03 14:23           ` Justin Tobler
2024-12-03 14:28             ` Patrick Steinhardt
2024-12-03 23:17               ` Junio C Hamano
2024-12-04  2:39                 ` Junio C Hamano
2024-11-27 23:33     ` [PATCH v3 4/4] transport: propagate fsck configuration during bundle fetch Justin Tobler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241127005707.319881-1-jltobler@gmail.com \
    --to=jltobler@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).