From: Caleb White <cdwhite3@pm.me>
To: git@vger.kernel.org
Cc: Caleb White <cdwhite3@pm.me>
Subject: [PATCH 0/2] Ensure unique worktree ids across repositories
Date: Fri, 29 Nov 2024 02:44:24 +0000 [thread overview]
Message-ID: <20241128-wt_unique_ids-v1-0-30345d010e43@pm.me> (raw)
The `es/worktree-repair-copied` topic added support for repairing a
worktree from a copy scenario. I noted[1,2] that the topic added the
ability for a repository to "take over" a worktree from another
repository if the worktree_id matched a worktree inside the current
repository which can happen if two repositories use the same worktree name.
This series teaches Git to create worktrees with a unique suffix so
that the worktree_id is unique across all repositories even if they have
the same name. For example creating a worktree `develop` would look like:
foo/
├── .git/worktrees/develop-5445874156/
└── develop/
bar/
├── .git/worktrees/develop-1549518426/
└── develop/
The actual worktree directory name is still `develop`, but the
worktree_id is unique and prevents the "take over" scenario. The suffix
is given by the `git_rand()` function, but I'm open to suggestions if
there's a better random or hashing function to use.
[1]: https://lore.kernel.org/git/20241008153035.71178-1-cdwhite3@pm.me/
[2]: https://lore.kernel.org/git/r4zmcET41Skr_FMop47AKd7cms9E8bKPSvHuAUpnYavzKEY6JybJta0_7GfuYB0q-gD-XNcvh5VDTfiT3qthGKjqhS1sbT4M2lUABynOz2Q=@pm.me/
Signed-off-by: Caleb White <cdwhite3@pm.me>
---
Caleb White (2):
worktree: add worktree with unique suffix
worktree: rename worktree id during worktree move
Documentation/git-worktree.txt | 5 +-
builtin/worktree.c | 30 ++++++++++++
t/t0035-safe-bare-repository.sh | 4 +-
t/t0600-reffiles-backend.sh | 10 ++--
t/t0601-reffiles-pack-refs.sh | 4 +-
t/t0610-reftable-basics.sh | 54 +++++++++++-----------
t/t1407-worktree-ref-store.sh | 4 +-
t/t1410-reflog.sh | 10 ++--
t/t1415-worktree-refs.sh | 26 +++++------
t/t1450-fsck.sh | 14 +++---
t/t1500-rev-parse.sh | 6 +--
t/t2400-worktree-add.sh | 51 +++++++++++----------
t/t2401-worktree-prune.sh | 20 ++++----
t/t2403-worktree-move.sh | 38 ++++++++--------
t/t2405-worktree-submodule.sh | 10 ++--
t/t2406-worktree-repair.sh | 93 ++++++++++++++++++++++++--------------
t/t2407-worktree-heads.sh | 27 +++++------
t/t3200-branch.sh | 10 ++--
t/t5304-prune.sh | 2 +-
t/t7412-submodule-absorbgitdirs.sh | 4 +-
20 files changed, 239 insertions(+), 183 deletions(-)
---
base-commit: 090d24e9af6e9f59c3f7bee97c42bb1ae3c7f559
change-id: 20241127-wt_unique_ids-1ffd7ea0bb19
prerequisite-change-id: 20241025-wt_relative_options-afa41987bc32:v5
prerequisite-patch-id: 179410e257e8eedf100f4f9faa9467cbbba4d61b
prerequisite-patch-id: 56ffe0afeadd511c9eef5f548a371659b040acab
prerequisite-patch-id: 809c1314e5dfa966f4f3d73b52f286f8aa89370f
prerequisite-patch-id: cf5f9491c8f8e58d1e0e103a5f8c64c55f2896e3
prerequisite-patch-id: 3d3bb3cc81d3030b1d27c39fdb4cf0e383937f89
prerequisite-patch-id: 62a09496d98d78a6bd1f9150ba887ee72359c7ee
prerequisite-patch-id: 5527e4b745963dd4fa08029491fcbfe3d91d5104
prerequisite-patch-id: bf433443e90939a493fa586de30938f78cb77020
Best regards,
--
Caleb White <cdwhite3@pm.me>
next reply other threads:[~2024-11-29 2:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 2:44 Caleb White [this message]
2024-11-29 2:44 ` [PATCH 1/2] worktree: add worktree with unique suffix Caleb White
2024-11-29 2:44 ` [PATCH 2/2] worktree: rename worktree id during worktree move Caleb White
2024-11-29 2:49 ` [PATCH 0/2] Ensure unique worktree ids across repositories Caleb White
2024-11-29 3:14 ` Junio C Hamano
2024-11-29 3:31 ` Caleb White
2024-12-01 4:38 ` Junio C Hamano
2024-11-29 11:05 ` shejialuo
2024-11-29 15:58 ` Caleb White
2024-11-29 17:32 ` shejialuo
2024-11-29 20:39 ` Caleb White
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241128-wt_unique_ids-v1-0-30345d010e43@pm.me \
--to=cdwhite3@pm.me \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).