From: Meet Soni <meetsoni3017@gmail.com>
To: git@vger.kernel.org
Cc: shubham.kanodia10@gmail.com, Meet Soni <meetsoni3017@gmail.com>
Subject: [RFC PATCH 0/3] refspec: centralize refspec-related logic
Date: Wed, 22 Jan 2025 13:21:51 +0530 [thread overview]
Message-ID: <20250122075154.5697-1-meetsoni3017@gmail.com> (raw)
As Patrick pointed out in [1], the logic related to refspec is currently
split across multiple headers. This patch series addresses that by
relocating refspec-related logic from remote to refspec for improved
cohesion.
There are a few functions that seem to be on the borderline. They seem
to have refspec-related logic, but also contain some elements related
to remote logic, so I'm unsure whether they should be moved.
Specifically:
* get_fetch_map()
* count_refspec_match()
* check_push_refs()
* match_push_refs()
[1]: https://lore.kernel.org/git/ZysQvUyxgdRqjvj2@pks.im/
Meet Soni (3):
refspec: relocate omit_name_by_refspec and related functions
refspec: relocate query related functions
refspec: relocate apply_refspecs and related funtions
refspec.c | 203 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
refspec.h | 23 +++++++
remote.c | 201 -----------------------------------------------------
remote.h | 15 ----
4 files changed, 226 insertions(+), 216 deletions(-)
base-commit: efff4a85a4fce58b2aa850c6fbf4d8828329f51d
--
2.34.1
next reply other threads:[~2025-01-22 7:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 7:51 Meet Soni [this message]
2025-01-22 7:51 ` [RFC PATCH 1/3] refspec: relocate omit_name_by_refspec and related functions Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt
2025-01-22 7:51 ` [RFC PATCH 2/3] refspec: relocate query " Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt
2025-01-22 7:51 ` [RFC PATCH 3/3] refspec: relocate apply_refspecs and related funtions Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt
2025-01-24 8:01 ` [RFC PATCH 0/3] refspec: centralize refspec-related logic Patrick Steinhardt
2025-01-24 17:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250122075154.5697-1-meetsoni3017@gmail.com \
--to=meetsoni3017@gmail.com \
--cc=git@vger.kernel.org \
--cc=shubham.kanodia10@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).