From: Seyi Kuforiji <kuforiji98@gmail.com>
To: git@vger.kernel.org
Cc: ps@pks.im, phillip.wood@dunelm.org.uk,
Seyi Kuforiji <kuforiji98@gmail.com>
Subject: [PATCH v3 0/4] t/unit-tests: convert unit-tests to use clar
Date: Tue, 25 Feb 2025 11:10:40 +0100 [thread overview]
Message-ID: <20250225101044.84210-1-kuforiji98@gmail.com> (raw)
In-Reply-To: <20250224152704.70289-1-kuforiji98@gmail.com>
Hello,
This small patch series transitions a couple more of our existing unit
test files to the Clar testing framework. This change is part of our
ongoing effort to standardize our testing framework to enhance
maintainability.
Changes in v3:
- minor code change based on review
Thanks
Seyi
Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Philip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
Seyi Kuforiji (4):
t/unit-tests: implement clar specific oid helper functions
t/unit-tests: convert oid-array test to use clar test framework
t/unit-tests: convert oidmap test to use clar test framework
t/unit-tests: convert oidtree test to use clar test framework
Makefile | 8 +-
t/meson.build | 8 +-
t/unit-tests/lib-oid.c | 32 ++--
t/unit-tests/lib-oid.h | 9 +-
t/unit-tests/{t-oid-array.c => u-oid-array.c} | 125 +++++++-------
t/unit-tests/{t-oidmap.c => u-oidmap.c} | 153 +++++++-----------
t/unit-tests/{t-oidtree.c => u-oidtree.c} | 79 ++++-----
t/unit-tests/unit-test.c | 2 +
8 files changed, 177 insertions(+), 239 deletions(-)
rename t/unit-tests/{t-oid-array.c => u-oid-array.c} (34%)
rename t/unit-tests/{t-oidmap.c => u-oidmap.c} (32%)
rename t/unit-tests/{t-oidtree.c => u-oidtree.c} (45%)
Range-diff against v2:
1: 7f14d0d574 ! 1: c5b6613617 t/unit-tests: implement clar specific oid helper functions
@@ t/unit-tests/lib-oid.c: int init_hash_algo(void)
+static void cl_parse_oid(const char *hex, struct object_id *oid,
const struct git_hash_algo *algop)
{
- int ret;
+- int ret;
size_t sz = strlen(hex);
struct strbuf buf = STRBUF_INIT;
2: 430f5c5007 = 2: d6cc4985a6 t/unit-tests: convert oid-array test to use clar test framework
3: 319cea1265 = 3: 1087752df5 t/unit-tests: convert oidmap test to use clar test framework
4: ea63a5c9f1 = 4: cda8dc194c t/unit-tests: convert oidtree test to use clar test framework
--
2.47.0.86.g15030f9556
next prev parent reply other threads:[~2025-02-25 10:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 8:29 [PATCH 0/5] t/unit-tests: convert unit-tests to use clar Seyi Kuforiji
2025-02-20 8:29 ` [PATCH 1/5] t/unit-tests: implement oid helper functions in unit-tests.{c,h} Seyi Kuforiji
2025-02-20 14:38 ` Phillip Wood
2025-02-21 7:59 ` Patrick Steinhardt
2025-02-21 7:59 ` Patrick Steinhardt
2025-02-21 14:50 ` phillip.wood123
2025-02-20 8:29 ` [PATCH 2/5] t/unit-tests: convert oid-array test to use clar Seyi Kuforiji
2025-02-20 14:38 ` Phillip Wood
2025-02-24 9:11 ` Seyi Chamber
2025-02-24 10:12 ` phillip.wood123
2025-02-20 8:29 ` [PATCH 3/5] t/unit-tests: convert oidmap " Seyi Kuforiji
2025-02-21 10:04 ` phillip.wood123
2025-02-24 10:56 ` Seyi Chamber
2025-02-20 8:29 ` [PATCH 4/5] t/unit-tests: convert oidtree " Seyi Kuforiji
2025-02-21 14:48 ` phillip.wood123
2025-02-20 8:29 ` [PATCH 5/5] t/unit-tests: remove lib-oid.{c,h,o} Seyi Kuforiji
2025-02-21 14:52 ` [PATCH 0/5] t/unit-tests: convert unit-tests to use clar phillip.wood123
2025-02-24 15:27 ` [PATCH v2 0/4] " Seyi Kuforiji
2025-02-24 15:27 ` [PATCH v2 1/4] t/unit-tests: implement clar specific oid helper functions Seyi Kuforiji
2025-02-24 17:55 ` Junio C Hamano
2025-02-25 7:14 ` Seyi Chamber
2025-02-25 7:56 ` Patrick Steinhardt
2025-02-24 15:27 ` [PATCH v2 2/4] t/unit-tests: convert oid-array test to use clar test framework Seyi Kuforiji
2025-02-24 15:27 ` [PATCH v2 3/4] t/unit-tests: convert oidmap " Seyi Kuforiji
2025-02-24 15:27 ` [PATCH v2 4/4] t/unit-tests: convert oidtree " Seyi Kuforiji
2025-02-25 10:10 ` Seyi Kuforiji [this message]
2025-02-25 10:10 ` [PATCH v3 1/4] t/unit-tests: implement clar specific oid helper functions Seyi Kuforiji
2025-02-25 10:10 ` [PATCH v3 2/4] t/unit-tests: convert oid-array test to use clar test framework Seyi Kuforiji
2025-02-25 10:10 ` [PATCH v3 3/4] t/unit-tests: convert oidmap " Seyi Kuforiji
2025-02-25 10:10 ` [PATCH v3 4/4] t/unit-tests: convert oidtree " Seyi Kuforiji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225101044.84210-1-kuforiji98@gmail.com \
--to=kuforiji98@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).