From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
To: git@vger.kernel.org
Cc: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Subject: [GSoC][RFC PATCH 2/6] builtin/log: die if -k and --suject-extra-prefix are used together
Date: Mon, 3 Mar 2025 19:00:25 -0300 [thread overview]
Message-ID: <20250303220029.10716-3-lucasseikioshiro@gmail.com> (raw)
In-Reply-To: <20250303220029.10716-1-lucasseikioshiro@gmail.com>
When calling format-patch, -k keeps the commit title as the patch subject
and can't be used with other options that depend on the existence of a
prefix. This way, -k shouldn't also be used with --subject-extra-prefix,
as it introduces an extra prefix.
If -k and --subject-extra-prefix are used together, die.
Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---
builtin/log.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/builtin/log.c b/builtin/log.c
index 95667c93ca..52dc0301cf 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -2256,6 +2256,8 @@ int cmd_format_patch(int argc,
die(_("options '%s' and '%s' cannot be used together"), "-n", "-k");
if (cfg.keep_subject && cfg.subject_prefix)
die(_("options '%s' and '%s' cannot be used together"), "--subject-prefix/--rfc", "-k");
+ if (cfg.keep_subject && extra_prefix)
+ die(_("options '%s' and '%s' cannot be used together"), "--subject-extra-prefix", "-k");
rev.preserve_subject = cfg.keep_subject;
argc = setup_revisions(argc, argv, &rev, &s_r_opt);
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-03-03 22:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 22:00 [GSoC][RFC PATCH 0/6] Add --subject-extra-prefix flag to format-patch Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 1/6] builtin/log: add subject-extra-prefix " Lucas Seiki Oshiro
2025-03-03 22:00 ` Lucas Seiki Oshiro [this message]
2025-03-03 22:36 ` [GSoC][RFC PATCH 2/6] builtin/log: die if -k and --suject-extra-prefix are used together Eric Sunshine
2025-03-03 22:00 ` [GSoC][RFC PATCH 3/6] revision: add subject_extra_field to struct rev_info Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 4/6] builtin/log: fill subject extra prefix in format-patch Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 5/6] log-tree: add subject prefix in output email subject Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 6/6] t4014: add tests for the new flag --subject-extra-prefix Lucas Seiki Oshiro
2025-03-03 23:08 ` [GSoC][RFC PATCH 0/6] Add --subject-extra-prefix flag to format-patch Junio C Hamano
2025-03-04 7:32 ` Patrick Steinhardt
2025-03-04 22:06 ` Junio C Hamano
2025-03-04 13:05 ` Junio C Hamano
2025-03-04 23:19 ` Lucas Seiki Oshiro
2025-03-05 2:06 ` Junio C Hamano
2025-03-05 14:26 ` Lucas Seiki Oshiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303220029.10716-3-lucasseikioshiro@gmail.com \
--to=lucasseikioshiro@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).