From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
To: git@vger.kernel.org
Cc: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Subject: [GSoC][RFC PATCH 5/6] log-tree: add subject prefix in output email subject
Date: Mon, 3 Mar 2025 19:00:28 -0300 [thread overview]
Message-ID: <20250303220029.10716-6-lucasseikioshiro@gmail.com> (raw)
In-Reply-To: <20250303220029.10716-1-lucasseikioshiro@gmail.com>
When an extra subject prefix is provided by the user when calling
`format-patch --subject-extra-prefix`, insert it between brackets at the
beginning of the the patch subject. Don't change the behavior when this
flag is not used.
For example, this `format-patch` call:
`git format-patch -1 --subject-extra-prefix EXTRA -n -v2`
will create a patch with the subject beginning with:
`Subject: [EXTRA][PATCH v2 1/1]`
Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---
log-tree.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/log-tree.c b/log-tree.c
index 8b184d6776..d72ab25585 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -478,17 +478,21 @@ void fmt_output_commit(struct strbuf *filename,
void fmt_output_email_subject(struct strbuf *sb, struct rev_info *opt)
{
+ strbuf_addstr(sb, "Subject: ");
+
+ if (opt->subject_extra_prefix && *opt->subject_extra_prefix)
+ strbuf_addf(sb, "[%s]",
+ opt->subject_extra_prefix);
+
if (opt->total > 0) {
- strbuf_addf(sb, "Subject: [%s%s%0*d/%d] ",
+ strbuf_addf(sb, "[%s%s%0*d/%d] ",
opt->subject_prefix,
*opt->subject_prefix ? " " : "",
decimal_width(opt->total),
opt->nr, opt->total);
} else if (opt->total == 0 && opt->subject_prefix && *opt->subject_prefix) {
- strbuf_addf(sb, "Subject: [%s] ",
+ strbuf_addf(sb, "[%s] ",
opt->subject_prefix);
- } else {
- strbuf_addstr(sb, "Subject: ");
}
}
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-03-03 22:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 22:00 [GSoC][RFC PATCH 0/6] Add --subject-extra-prefix flag to format-patch Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 1/6] builtin/log: add subject-extra-prefix " Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 2/6] builtin/log: die if -k and --suject-extra-prefix are used together Lucas Seiki Oshiro
2025-03-03 22:36 ` Eric Sunshine
2025-03-03 22:00 ` [GSoC][RFC PATCH 3/6] revision: add subject_extra_field to struct rev_info Lucas Seiki Oshiro
2025-03-03 22:00 ` [GSoC][RFC PATCH 4/6] builtin/log: fill subject extra prefix in format-patch Lucas Seiki Oshiro
2025-03-03 22:00 ` Lucas Seiki Oshiro [this message]
2025-03-03 22:00 ` [GSoC][RFC PATCH 6/6] t4014: add tests for the new flag --subject-extra-prefix Lucas Seiki Oshiro
2025-03-03 23:08 ` [GSoC][RFC PATCH 0/6] Add --subject-extra-prefix flag to format-patch Junio C Hamano
2025-03-04 7:32 ` Patrick Steinhardt
2025-03-04 22:06 ` Junio C Hamano
2025-03-04 13:05 ` Junio C Hamano
2025-03-04 23:19 ` Lucas Seiki Oshiro
2025-03-05 2:06 ` Junio C Hamano
2025-03-05 14:26 ` Lucas Seiki Oshiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303220029.10716-6-lucasseikioshiro@gmail.com \
--to=lucasseikioshiro@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).