git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zheng Yuting <05zyt30@gmail.com>
To: git@vger.kernel.org
Cc: Zheng Yuting <05ZYT30@gmail.com>
Subject: [PATCH 0/1] [GSoC]smtp_auth_maybe: improve smtp authentication error handling logic
Date: Fri,  7 Mar 2025 20:39:22 +0800	[thread overview]
Message-ID: <20250307123934.2064275-1-05ZYT30@gmail.com> (raw)

This patch enhances error handling in the smtp_auth_maybe() function by
distinguishing between temporary errors and permanent authentication failures.

- For temporary errors (e.g., timeout, network issues, etc.), the function
logs a warning and returns 1, allowing retries.

- For permanent errors (e.g., invalid credentials), it returns 0.

Additionally, it separates handling for SASL and plain authentication
to prevent rejecting valid credentials due to non-credential errors,
improving robustness.

Zheng Yuting (1):
  improve smtp authentication error handling logic

 git-send-email.perl | 30 ++++++++++++++++++++++--------
 1 file changed, 22 insertions(+), 8 deletions(-)

--
2.49.0.rc0.57.gdb91954e18

             reply	other threads:[~2025-03-07 12:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 12:39 Zheng Yuting [this message]
2025-03-07 12:39 ` [PATCH 1/1] Improve SMTP authentication error handling logic Zheng Yuting
2025-03-10 22:14   ` Karthik Nayak
2025-03-11  8:03     ` Yuting Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250307123934.2064275-1-05ZYT30@gmail.com \
    --to=05zyt30@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).