From: Mark Levedahl <mlevedahl@gmail.com>
To: j6t@kdbg.org, johannes.schindelin@gmx.de
Cc: git@vger.kernel.org, Mark Levedahl <mlevedahl@gmail.com>
Subject: [PATCH v2 0/3] gitk: override PATH search only on Windows
Date: Mon, 31 Mar 2025 23:00:59 -0400 [thread overview]
Message-ID: <20250401030102.297272-1-mlevedahl@gmail.com> (raw)
In-Reply-To: <5b09f1c2-be58-43a2-9908-7243b5207251@gmail.com>
Restrict overrides of exec/open to Windows only, as
the need for this is Tcl adding the current working directory
to $PATH on Windows. Recent modifications to this render
gitk unusable on Cygwin, isolating these overrides to Windows only
both fixes that breakage andk reduces the liklihood of similar
issues in the future.
patch summary:
1 - modifies the existing code to restrict the overrides
to Windows, restoring other platorms to native exec/open.
2 - remove now superflous variable _search_exe.
3 - fix the override code to avoid path search given a
relative path like foo/bar.
---
Changes since v1 - fixed commit ID reference for git-gui, otherwise
improved commit message in patch 1.
Added patches 2 and 3.
Mark Levedahl (3):
gitk: override $PATH search only on Windows
gitk: _search_exe is no longer needed
gitk: limit PATH search to bare executable names
gitk | 147 +++++++++++++++++++++++------------------------------------
1 file changed, 58 insertions(+), 89 deletions(-)
--
2.49.0.99.31
next prev parent reply other threads:[~2025-04-01 3:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 12:34 git v2.49.0 - gitk regression on Cygwin Mark Levedahl
2025-03-28 17:30 ` Johannes Sixt
2025-03-29 21:49 ` Mark Levedahl
2025-03-31 15:12 ` [PATCH] gitk - override $PATH search only on Windows Mark Levedahl
2025-03-31 17:12 ` Johannes Sixt
2025-03-31 19:29 ` Mark Levedahl
2025-04-01 3:00 ` Mark Levedahl [this message]
2025-04-01 3:01 ` [PATCH v2 1/3] gitk: " Mark Levedahl
2025-04-01 3:01 ` [PATCH v2 2/3] gitk: _search_exe is no longer needed Mark Levedahl
2025-04-01 3:01 ` [PATCH v2 3/3] gitk: limit PATH search to bare executable names Mark Levedahl
2025-04-01 16:10 ` [PATCH v2 0/3] gitk: override PATH search only on Windows Johannes Schindelin
2025-04-01 16:44 ` Mark Levedahl
2025-04-01 16:40 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250401030102.297272-1-mlevedahl@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).