git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
To: git@vger.kernel.org
Cc: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Subject: [GSoC PATCH] revision: remove log_reencode field from rev_info
Date: Mon, 14 Apr 2025 12:14:38 -0300	[thread overview]
Message-ID: <20250414151438.22232-1-lucasseikioshiro@gmail.com> (raw)

Remove the log_reencode field from struct rev-info, as it is not used.

Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---

Just a simple cleanup patch removing this unused field.

When I was working in a previous patchset (this:
https://lore.kernel.org/git/20250303220029.10716-1-lucasseikioshiro@gmail.com/)
I noticed that this field wasn't used anywhere in the code.

I also saw that it hasn't been used since it's introduction in 2006, in
commit 52883fb.

 revision.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/revision.h b/revision.h
index 71e984c452..87f8d798c2 100644
--- a/revision.h
+++ b/revision.h
@@ -292,7 +292,6 @@ struct rev_info {
 	struct string_list *ref_message_ids;
 	int		add_signoff;
 	const char	*extra_headers;
-	const char	*log_reencode;
 	const char	*subject_prefix;
 	int		patch_name_max;
 	int		no_inline;
-- 
2.39.5 (Apple Git-154)


             reply	other threads:[~2025-04-14 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 15:14 Lucas Seiki Oshiro [this message]
2025-04-16  8:54 ` [GSoC PATCH] revision: remove log_reencode field from rev_info Patrick Steinhardt
2025-04-16 16:02   ` Lucas Seiki Oshiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250414151438.22232-1-lucasseikioshiro@gmail.com \
    --to=lucasseikioshiro@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).