From: Usman Akinyemi <usmanakinyemi202@gmail.com>
To: git@vger.kernel.org, christian.couder@gmail.com
Cc: gitster@pobox.com, johncai86@gmail.com, me@ttaylorr.com,
ps@pks.im, shejialuo@gmail.com, phillip.wood123@gmail.com
Subject: [PATCH 0/2] remove unnecessary if statement
Date: Sun, 20 Apr 2025 08:24:31 +0530 [thread overview]
Message-ID: <20250420025501.183290-1-usmanakinyemi202@gmail.com> (raw)
Since we already teach the `repo_config()` in "f29f1990b5
(config: teach repo_config to allow `repo` to be NULL, 2025-03-08)"
to allow `repo` to be NULL, no need to check if `repo` is NULL
before calling `repo_config()`.
This was suggested by Patrick Steinhardt <ps@pks.im>
Usman Akinyemi (2):
builtin/add: remove unnecessary if statement
builtin/difftool: remove unnecessary if statement
builtin/add.c | 3 +--
builtin/difftool.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
--
2.49.0
next reply other threads:[~2025-04-20 2:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-20 2:54 Usman Akinyemi [this message]
2025-04-20 2:54 ` [PATCH 1/2] builtin/add: remove unnecessary if statement Usman Akinyemi
2025-04-20 2:54 ` [PATCH 2/2] builtin/difftool: " Usman Akinyemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250420025501.183290-1-usmanakinyemi202@gmail.com \
--to=usmanakinyemi202@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johncai86@gmail.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
--cc=shejialuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).