git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	 Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH] gitlab-ci: always run MSVC-based Meson job
Date: Mon, 28 Apr 2025 11:32:12 +0200	[thread overview]
Message-ID: <20250428-pks-gitlab-ci-execute-win-meson-v1-1-f68683552b9e@pks.im> (raw)

With 7304bd2bc39 (ci: wire up Visual Studio build with Meson,
2025-01-22) we have introduced a CI job that builds and tests Git with
Microsoft Visual Studio via Meson. This job is only being executed by
default on GitHub Workflows though -- on GitLab CI it is marked as a
"manual" job, so the developer has to actively trigger these jobs.

The consequence of this split is that any breakage specific to this job
is only noticed by developers who mainly work with GitHub. Let's improve
this situation by also running the job by default on GitLab CI.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
As proposed in [1]. A test run of this pipeline can be found at [2].
Thanks!

Patrick

[1]: <aA8ymUzWM2t0QkFP@pks.im>
[2]: https://gitlab.com/gitlab-org/git/-/merge_requests/349
---
 .gitlab-ci.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 4798b283745..bb6d5b976cd 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -173,7 +173,6 @@ build:msvc-meson:
 test:msvc-meson:
   extends: .msvc-meson
   stage: test
-  when: manual
   timeout: 6h
   needs:
     - job: "build:msvc-meson"

---
base-commit: f65182a99e545d2f2bc22e6c1c2da192133b16a3
change-id: 20250428-pks-gitlab-ci-execute-win-meson-e54998fa7081


             reply	other threads:[~2025-04-28  9:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28  9:32 Patrick Steinhardt [this message]
2025-04-28 10:59 ` [PATCH] gitlab-ci: always run MSVC-based Meson job Johannes Schindelin
2025-04-28 18:44   ` Junio C Hamano
2025-05-06 10:39     ` Patrick Steinhardt
2025-05-06 13:17       ` Phillip Wood
2025-05-13  9:12 ` Patrick Steinhardt
2025-05-13 17:03   ` Junio C Hamano
2025-05-14  2:16     ` Patrick Steinhardt
2025-05-14 16:55       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250428-pks-gitlab-ci-execute-win-meson-v1-1-f68683552b9e@pks.im \
    --to=ps@pks.im \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).