From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH v3 3/6] tests: prepare for a world without whatchanged
Date: Fri, 2 May 2025 17:58:11 -0700 [thread overview]
Message-ID: <20250503005814.3030099-4-gitster@pobox.com> (raw)
In-Reply-To: <20250503005814.3030099-1-gitster@pobox.com>
Some tests on fast-import run "git whatchanged" without even
checking the output from the command. It is tempting to remove the
calls altogether since they are not doing anything useful, but they
presumably were placed while the tests were developped to manually
sanity check which paths were touched.
Replace these calls with "git log --raw", which is a rough
equivalent in the more modern Git.
This does not remove "git whatchanged", but we no longer have to
worry about adjusting these places when we eventually do.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
t/t9300-fast-import.sh | 12 ++++++------
t/t9301-fast-import-notes.sh | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
index b258dbf1df..4dc3d645bf 100755
--- a/t/t9300-fast-import.sh
+++ b/t/t9300-fast-import.sh
@@ -120,7 +120,7 @@ test_expect_success 'A: create pack from stdin' '
INPUT_END
git fast-import --export-marks=marks.out <input &&
- git whatchanged main
+ git log --raw main
'
test_expect_success 'A: verify pack' '
@@ -279,7 +279,7 @@ test_expect_success 'A: verify marks import does not crash' '
INPUT_END
git fast-import --import-marks=marks.out <input &&
- git whatchanged verify--import-marks
+ git log --raw verify--import-marks
'
test_expect_success 'A: verify pack' '
@@ -652,7 +652,7 @@ test_expect_success 'C: incremental import create pack from stdin' '
INPUT_END
git fast-import <input &&
- git whatchanged branch
+ git log --raw branch
'
test_expect_success 'C: verify pack' '
@@ -715,7 +715,7 @@ test_expect_success 'D: inline data in commit' '
INPUT_END
git fast-import <input &&
- git whatchanged branch
+ git log --raw branch
'
test_expect_success 'D: verify pack' '
@@ -882,7 +882,7 @@ test_expect_success 'H: deletall, add 1' '
INPUT_END
git fast-import <input &&
- git whatchanged H
+ git log --raw H
'
test_expect_success 'H: verify pack' '
@@ -2066,7 +2066,7 @@ test_expect_success 'Q: commit notes' '
INPUT_END
git fast-import <input &&
- git whatchanged notes-test
+ git log --raw notes-test
'
test_expect_success 'Q: verify pack' '
diff --git a/t/t9301-fast-import-notes.sh b/t/t9301-fast-import-notes.sh
index 1ae4d7c0d3..e62173cf1f 100755
--- a/t/t9301-fast-import-notes.sh
+++ b/t/t9301-fast-import-notes.sh
@@ -76,7 +76,7 @@ INPUT_END
test_expect_success 'set up main branch' '
git fast-import <input &&
- git whatchanged main
+ git log --raw main
'
commit4=$(git rev-parse refs/heads/main)
--
2.49.0-601-ga5925c3955
next prev parent reply other threads:[~2025-05-03 0:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 21:34 [PATCH 0/2] Nominating "whatchanged" for removal Junio C Hamano
2025-05-01 21:34 ` [PATCH 1/2] you-still-use-that??: help deprecating commands " Junio C Hamano
2025-05-01 21:34 ` [PATCH 2/2] whatchanged: require --i-still-use-this Junio C Hamano
2025-05-01 22:23 ` Junio C Hamano
2025-05-01 22:59 ` [PATCH v2 0/2] Nominating "whatchanged" for removal Junio C Hamano
2025-05-01 22:59 ` [PATCH v2 1/2] you-still-use-that??: help deprecating commands " Junio C Hamano
2025-05-01 22:59 ` [PATCH v2 2/2] whatchanged: require --i-still-use-this Junio C Hamano
2025-05-02 9:08 ` Patrick Steinhardt
2025-05-02 16:49 ` Junio C Hamano
2025-05-05 6:10 ` Patrick Steinhardt
2025-05-02 9:08 ` [PATCH v2 0/2] Nominating "whatchanged" for removal Patrick Steinhardt
2025-05-02 16:46 ` Junio C Hamano
2025-05-03 0:58 ` [PATCH v3 0/6] " Junio C Hamano
2025-05-03 0:58 ` [PATCH v3 1/6] you-still-use-that??: help deprecating commands " Junio C Hamano
2025-05-12 17:35 ` Elijah Newren
2025-05-03 0:58 ` [PATCH v3 2/6] doc: prepare for a world without whatchanged Junio C Hamano
2025-05-12 17:36 ` Elijah Newren
2025-05-03 0:58 ` Junio C Hamano [this message]
2025-05-05 6:56 ` [PATCH v3 3/6] tests: " Patrick Steinhardt
2025-05-12 17:36 ` Elijah Newren
2025-05-03 0:58 ` [PATCH v3 4/6] whatchanged: require --i-still-use-this Junio C Hamano
2025-05-05 6:56 ` Patrick Steinhardt
2025-05-05 20:49 ` Junio C Hamano
2025-05-03 0:58 ` [PATCH v3 5/6] whatchanged: remove when built with WITH_BREAKING_CHANGES Junio C Hamano
2025-05-05 6:56 ` Patrick Steinhardt
2025-05-05 20:57 ` Junio C Hamano
2025-05-03 0:58 ` [PATCH v3 6/6] whatschanged: list it in BreakingChanges document Junio C Hamano
2025-05-12 17:36 ` Elijah Newren
2025-05-12 18:35 ` Junio C Hamano
2025-05-12 19:03 ` [PATCH v4 0/6] Nominating "whatchanged" for removal Junio C Hamano
2025-05-12 19:03 ` [PATCH v4 1/6] you-still-use-that??: help deprecating commands " Junio C Hamano
2025-05-12 19:03 ` [PATCH v4 2/6] doc: prepare for a world without whatchanged Junio C Hamano
2025-05-12 19:03 ` [PATCH v4 3/6] tests: " Junio C Hamano
2025-05-12 19:03 ` [PATCH v4 4/6] whatchanged: require --i-still-use-this Junio C Hamano
2025-05-14 13:38 ` Junio C Hamano
2025-05-12 19:03 ` [PATCH v4 5/6] whatchanged: remove when built with WITH_BREAKING_CHANGES Junio C Hamano
2025-05-12 19:03 ` [PATCH v4 6/6] whatschanged: list it in BreakingChanges document Junio C Hamano
2025-05-12 21:21 ` [PATCH v4 0/6] Nominating "whatchanged" for removal Elijah Newren
2025-05-12 22:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250503005814.3030099-4-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).