git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Justin Tobler <jltobler@gmail.com>
To: git@vger.kernel.org
Cc: ps@pks.im, karthik.188@gmail.com, Justin Tobler <jltobler@gmail.com>
Subject: [RFC PATCH 1/2] t5412: test receive-pack connectivity check
Date: Tue,  6 May 2025 22:02:48 -0500	[thread overview]
Message-ID: <20250507030249.4802-2-jltobler@gmail.com> (raw)
In-Reply-To: <20250507030249.4802-1-jltobler@gmail.com>

As part of git-recieve-pack(1), the connectivity of objects is checked.
Add a test validating that git-receive-pack(1) fails due to an incoming
packfile that would leave the repository with missing objects.

Signed-off-by: Justin Tobler <jltobler@gmail.com>
---
 t/meson.build           |  1 +
 t/t5412-receive-pack.sh | 27 +++++++++++++++++++++++++++
 2 files changed, 28 insertions(+)
 create mode 100755 t/t5412-receive-pack.sh

diff --git a/t/meson.build b/t/meson.build
index 43c9750b88..81066668b9 100644
--- a/t/meson.build
+++ b/t/meson.build
@@ -630,6 +630,7 @@ integration_tests = [
   't5409-colorize-remote-messages.sh',
   't5410-receive-pack-alternates.sh',
   't5411-proc-receive-hook.sh',
+  't5412-receive-pack.sh',
   't5500-fetch-pack.sh',
   't5501-fetch-push-alternates.sh',
   't5502-quickfetch.sh',
diff --git a/t/t5412-receive-pack.sh b/t/t5412-receive-pack.sh
new file mode 100755
index 0000000000..190c7d3624
--- /dev/null
+++ b/t/t5412-receive-pack.sh
@@ -0,0 +1,27 @@
+#!/bin/sh
+
+test_description='git receive-pack connectivity checks'
+
+. ./test-lib.sh
+
+test_expect_success 'receive-pack missing objects fails connectivity check' '
+	test_when_finished rm -rf repo remote.git setup.git &&
+
+	git init repo &&
+	git -C repo commit --allow-empty -m 1 &&
+	git clone --bare repo setup.git &&
+	git -C repo commit --allow-empty -m 2 &&
+
+	# Capture git-send-pack(1) output sent to git-receive-pack(1).
+	git -C repo send-pack ../setup.git --all \
+		--receive-pack="tee ${SQ}$(pwd)/out${SQ} | git-receive-pack" &&
+
+	# Replay captured git-send-pack(1) output on new empty repository.
+	git init --bare remote.git &&
+	git receive-pack remote.git <out >actual &&
+
+	test_grep "fatal: Failed to traverse parents" actual &&
+	test_must_fail git -C remote.git cat-file -e $(git -C repo rev-parse HEAD)
+'
+
+test_done
-- 
2.49.0.111.g5b97a56fa0


  reply	other threads:[~2025-05-07  3:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07  3:02 [RFC PATCH 0/2] builtin/receive-pack: introduce option to skip connectivity checks Justin Tobler
2025-05-07  3:02 ` Justin Tobler [this message]
2025-05-07 13:28   ` [RFC PATCH 1/2] t5412: test receive-pack connectivity check Patrick Steinhardt
2025-05-19 21:08     ` Justin Tobler
2025-05-07  3:02 ` [RFC PATCH 2/2] builtin/receive-pack: add option to skip " Justin Tobler
2025-05-07 13:28   ` Patrick Steinhardt
2025-05-07 17:20     ` Junio C Hamano
2025-05-20  1:49 ` [PATCH 0/2] builtin/receive-pack: introduce option to skip connectivity checks Justin Tobler
2025-05-20  1:49   ` [PATCH 1/2] t5410: test receive-pack connectivity check Justin Tobler
2025-05-20  9:11     ` Karthik Nayak
2025-05-20  1:49   ` [PATCH 2/2] builtin/receive-pack: add option to skip " Justin Tobler
2025-05-20  5:17     ` Patrick Steinhardt
2025-05-20 15:10       ` Justin Tobler
2025-05-20  9:16     ` Karthik Nayak
2025-05-20 16:32   ` [PATCH v2 0/2] builtin/receive-pack: introduce option to skip connectivity checks Justin Tobler
2025-05-20 16:32     ` [PATCH v2 1/2] t5410: test receive-pack connectivity check Justin Tobler
2025-05-20 16:32     ` [PATCH v2 2/2] builtin/receive-pack: add option to skip " Justin Tobler
2025-06-02 15:01       ` Johannes Schindelin
2025-06-02 15:59         ` Justin Tobler
2025-06-02 16:06           ` Johannes Schindelin
2025-06-02 18:16             ` Junio C Hamano
2025-06-03 12:40           ` Patrick Steinhardt
2025-06-05 10:17             ` Johannes Schindelin
2025-06-05 11:00               ` Patrick Steinhardt
2025-05-22  9:09     ` [PATCH v2 0/2] builtin/receive-pack: introduce option to skip connectivity checks Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250507030249.4802-2-jltobler@gmail.com \
    --to=jltobler@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).