From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: stolee@gmail.com, Karthik Nayak <karthik.188@gmail.com>
Subject: [PATCH] t: remove unexpected SANITIZE_LEAK variables
Date: Tue, 20 May 2025 16:40:12 +0200 [thread overview]
Message-ID: <20250520-kn-remove-unexpected-exported-v1-1-bb60cec57e84@gmail.com> (raw)
As of 1fc7ddf35b (test-lib: unconditionally enable leak checking,
2024-11-20), both the `GIT_TEST_PASSING_SANITIZE_LEAK` and
`TEST_PASSES_SANITIZE_LEAK` variables no longer have any meaning, the
leak checks are enabled by default. However, some newly added tests
include them by mistake. Let's clean this up.
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
t/perf/p5313-pack-objects.sh | 3 ---
t/perf/p5314-name-hash.sh | 3 ---
t/t6601-path-walk.sh | 2 --
3 files changed, 8 deletions(-)
diff --git a/t/perf/p5313-pack-objects.sh b/t/perf/p5313-pack-objects.sh
index be5229a0ec..786a2c1c6f 100755
--- a/t/perf/p5313-pack-objects.sh
+++ b/t/perf/p5313-pack-objects.sh
@@ -3,9 +3,6 @@
test_description='Tests pack performance using bitmaps'
. ./perf-lib.sh
-GIT_TEST_PASSING_SANITIZE_LEAK=0
-export GIT_TEST_PASSING_SANITIZE_LEAK
-
test_perf_large_repo
test_expect_success 'create rev input' '
diff --git a/t/perf/p5314-name-hash.sh b/t/perf/p5314-name-hash.sh
index 4ef0ba7711..235cdfc824 100755
--- a/t/perf/p5314-name-hash.sh
+++ b/t/perf/p5314-name-hash.sh
@@ -3,9 +3,6 @@
test_description='Tests pack performance using bitmaps'
. ./perf-lib.sh
-GIT_TEST_PASSING_SANITIZE_LEAK=0
-export GIT_TEST_PASSING_SANITIZE_LEAK
-
test_perf_large_repo
test_size 'paths at head' '
diff --git a/t/t6601-path-walk.sh b/t/t6601-path-walk.sh
index c89b0f1e19..8d187f7279 100755
--- a/t/t6601-path-walk.sh
+++ b/t/t6601-path-walk.sh
@@ -1,7 +1,5 @@
#!/bin/sh
-TEST_PASSES_SANITIZE_LEAK=true
-
test_description='direct path-walk API tests'
. ./test-lib.sh
next reply other threads:[~2025-05-20 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 14:40 Karthik Nayak [this message]
2025-05-20 21:16 ` [PATCH] t: remove unexpected SANITIZE_LEAK variables Justin Tobler
2025-05-20 22:09 ` Junio C Hamano
2025-05-22 6:06 ` Jeff King
2025-05-22 6:09 ` Jeff King
2025-05-22 9:06 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250520-kn-remove-unexpected-exported-v1-1-bb60cec57e84@gmail.com \
--to=karthik.188@gmail.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).