From: Jeff King <peff@peff.net>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, stolee@gmail.com
Subject: Re: [PATCH] t: remove unexpected SANITIZE_LEAK variables
Date: Thu, 22 May 2025 02:09:33 -0400 [thread overview]
Message-ID: <20250522060933.GA1135565@coredump.intra.peff.net> (raw)
In-Reply-To: <20250522060626.GB1137854@coredump.intra.peff.net>
On Thu, May 22, 2025 at 02:06:26AM -0400, Jeff King wrote:
> As a side note, we do still use the SANITIZE_LEAK prereq in a few
> places, and I believe that it does actually work. It might be nice to
> clean up any leaks in those few spots, though we probably want to keep
> the prereq around forever (e.g., if you introduce a test which shows off
> a leak and then fixes it later). All orthogonal to your patch, though,
> which looks good to me.
Ah, nevermind. These are all due to 8415595203 (t5601: work around leak
sanitizer issue, 2024-11-20). They are leak-free (and the tests pass on
my system), but apparently some upstream bug can cause issues.
-Peff
next prev parent reply other threads:[~2025-05-22 6:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 14:40 [PATCH] t: remove unexpected SANITIZE_LEAK variables Karthik Nayak
2025-05-20 21:16 ` Justin Tobler
2025-05-20 22:09 ` Junio C Hamano
2025-05-22 6:06 ` Jeff King
2025-05-22 6:09 ` Jeff King [this message]
2025-05-22 9:06 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522060933.GA1135565@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).