From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
To: git@vger.kernel.org
Cc: ps@pks.im, karthik.188@gmail.com,
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Subject: [GSoC PATCH v2 2/2] MyFirstContribution: add walken.c to meson.build
Date: Mon, 2 Jun 2025 17:50:21 -0300 [thread overview]
Message-ID: <20250602205021.4223-3-lucasseikioshiro@gmail.com> (raw)
In-Reply-To: <20250602205021.4223-1-lucasseikioshiro@gmail.com>
Instruct in the documentation to also add an entry in meson.build for
builtin/walken.c, as currently both Meson and Make are supported.
Helped-by: Karthik Nayak <karthik.188@gmail.com>
Helped-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---
Documentation/MyFirstObjectWalk.adoc | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/Documentation/MyFirstObjectWalk.adoc b/Documentation/MyFirstObjectWalk.adoc
index a4ba6e21ec..413a9fdb05 100644
--- a/Documentation/MyFirstObjectWalk.adoc
+++ b/Documentation/MyFirstObjectWalk.adoc
@@ -96,10 +96,23 @@ maintaining alphabetical ordering:
{ "walken", cmd_walken, RUN_SETUP },
----
-Add it to the `Makefile` near the line for `builtin/worktree.o`:
+Add an entry for the new command in the both the Make and Meson build system,
+before the entry for `worktree`:
+- In the `Makefile`:
----
+...
BUILTIN_OBJS += builtin/walken.o
+...
+----
+
+- In the `meson.build` file:
+----
+builtin_sources = [
+ ...
+ 'builtin/walken.c',
+ ...
+]
----
Build and test out your command, without forgetting to ensure the `DEVELOPER`
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-06-02 20:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 19:20 [GSoC PATCH 0/2] Update MyFirstObjectWalk with struct repository and meson Lucas Seiki Oshiro
2025-05-29 19:20 ` [GSoC PATCH 1/2] MyFirstContribution: use struct repository in examples Lucas Seiki Oshiro
2025-05-29 19:57 ` Karthik Nayak
2025-05-29 19:20 ` [GSoC PATCH 2/2] MyFirstContribution: add walken.c to meson.build Lucas Seiki Oshiro
2025-05-29 20:02 ` Karthik Nayak
2025-05-30 8:00 ` Patrick Steinhardt
2025-05-29 20:06 ` [GSoC PATCH 0/2] Update MyFirstObjectWalk with struct repository and meson Karthik Nayak
2025-06-02 20:50 ` [GSoC PATCH v2 0/2] MyFirstObjectWalk: update " Lucas Seiki Oshiro
2025-06-02 20:50 ` [GSoC PATCH v2 1/2] MyFirstContribution: use struct repository in examples Lucas Seiki Oshiro
2025-06-02 20:50 ` Lucas Seiki Oshiro [this message]
2025-06-03 6:08 ` [GSoC PATCH v2 0/2] MyFirstObjectWalk: update with struct repository and meson Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250602205021.4223-3-lucasseikioshiro@gmail.com \
--to=lucasseikioshiro@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).