git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
To: jayatheerthkulkarni2005@gmail.com
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: [PATCH v8 0/2] Avoid submodule overwritten and skip redundant active entries
Date: Sun,  8 Jun 2025 08:57:03 +0530	[thread overview]
Message-ID: <20250608032705.11990-1-jayatheerthkulkarni2005@gmail.com> (raw)
In-Reply-To: <CA+rGoLdTT3kdELUyHdZLWyy8e6AbfRU7kDFcVUdCmVtDi11hMw@mail.gmail.com>

The first patch i.e. prevent overwriting .gitmodules entry on path reuse
is exactly the same 

The second patch however i.e. 
skip redundant active entries when pattern covers path
has changed logic 
with the helper function being code maintainance because 
of the duplicated logic. I've tried to wrap it as much as 
possible to it's own core need without having to change it
unless the core way of submodules addition and active status
itself changes.

The CI was tested in which 
the only compiler error I found was 
osx-gcc
Which I suppose is already addressed,
apart from this all of the other tests 
ran successfully which includes the 
t7413 (prvious 9) and the new one.


K Jayatheerth (2):
  submodule: prevent overwriting .gitmodules entry on path reuse
  submodule: skip redundant active entries when pattern covers path

 builtin/submodule--helper.c    | 60 +++++++++++++++++++++++++++-------
 t/t7400-submodule-basic.sh     | 23 +++++++++++++
 t/t7413-submodule-is-active.sh | 15 +++++++++
 3 files changed, 87 insertions(+), 11 deletions(-)

-- 
2.49.GIT


  reply	other threads:[~2025-06-08  3:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-24  7:36 [PATCH v7 0/2] Avoid submodule overwritten and skip redundant active entries K Jayatheerth
2025-05-24  7:36 ` [PATCH v7 1/2] submodule: prevent overwriting .gitmodules entry on path reuse K Jayatheerth
2025-05-27 14:01   ` Junio C Hamano
2025-05-24  7:36 ` [PATCH v7 2/2] submodule: skip redundant active entries when pattern covers path K Jayatheerth
2025-05-27 14:42   ` Junio C Hamano
2025-05-29  4:23     ` JAYATHEERTH K
2025-06-04  4:22       ` Junio C Hamano
2025-06-06 14:41         ` JAYATHEERTH K
2025-06-08  3:27           ` K Jayatheerth [this message]
2025-06-08  3:27             ` [PATCH v8 1/2] submodule: prevent overwriting .gitmodules entry on path reuse K Jayatheerth
2025-07-09  2:50               ` D. Ben Knoble
2025-07-20 12:25                 ` JAYATHEERTH K
2025-07-25 17:28                   ` Ben Knoble
2025-06-08  3:27             ` [PATCH v8 2/2] submodule: skip redundant active entries when pattern covers path K Jayatheerth
2025-07-09  2:50               ` D. Ben Knoble
2025-07-09 14:52                 ` Junio C Hamano
2025-07-17 16:58               ` Junio C Hamano
2025-07-18 14:24                 ` JAYATHEERTH K
2025-07-07 22:34             ` [PATCH v8 0/2] Avoid submodule overwritten and skip redundant active entries Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250608032705.11990-1-jayatheerthkulkarni2005@gmail.com \
    --to=jayatheerthkulkarni2005@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).