git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] bswap.h: Move the overwriting of the ntohl*/ htonl* macros.
Date: Mon, 9 Jun 2025 23:57:17 +0200	[thread overview]
Message-ID: <20250609215717.gbaaVj7r@breakpoint.cc> (raw)
In-Reply-To: <xmqqmsajxo2i.fsf@gitster.g>

On 2025-06-07 14:02:29 [-0700], Junio C Hamano wrote:
> This seems to break Windows rather badly.
> 
> https://github.com/git/git/actions/runs/15511228119/job/43672455770#step:4:92
> 
> I'll eject it from my tree for now.

Okay. I prepared a revert the commit introducing the regression and then
tried to clean it up a bit taking this fallout into consideration.

Will post it tomorrow after some testing.

Sebastian

      reply	other threads:[~2025-06-09 21:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06 16:57 [PATCH] bswap.h: Move the overwriting of the ntohl*/ htonl* macros Sebastian Andrzej Siewior
2025-06-06 21:05 ` Junio C Hamano
2025-06-06 22:04   ` Sebastian Andrzej Siewior
2025-06-06 22:36     ` Junio C Hamano
2025-06-07 21:02       ` Junio C Hamano
2025-06-09 21:57         ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250609215717.gbaaVj7r@breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).