From: Usman Akinyemi <usmanakinyemi202@gmail.com>
To: git@vger.kernel.org
Cc: ps@pks.im, chriscool@tuxfamily.org, christian.couder@gmail.com,
gitster@pobox.com, me@ttaylorr.com, usmanakinyemi202@gmail.com
Subject: [PATCH v2 3/7] t/t1517: move ls-files -h test to t1517
Date: Mon, 7 Jul 2025 03:11:04 +0530 [thread overview]
Message-ID: <20250706214108.714499-4-usmanakinyemi202@gmail.com> (raw)
In-Reply-To: <20250706214108.714499-1-usmanakinyemi202@gmail.com>
The test 'ls-files does not crash with -h' checks that
the command exits cleanly with usage information, both inside and
outside of a repository.
Move this test from "t3004-ls-files-basic.sh" to
"t1517-outside-repo.sh" since it better fits with tests that check
command behavior outside a repository.
Suggested-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
---
t/t1517-outside-repo.sh | 7 +++++++
t/t3004-ls-files-basic.sh | 7 -------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh
index 92ad159b58..e04be2d811 100755
--- a/t/t1517-outside-repo.sh
+++ b/t/t1517-outside-repo.sh
@@ -128,4 +128,11 @@ test_expect_success 'for-each-ref does not crash with -h' '
test_grep "[Uu]sage: git for-each-ref " usage
'
+test_expect_success 'ls-files does not crash with -h' '
+ test_expect_code 129 git ls-files -h >usage &&
+ test_grep "[Uu]sage: git ls-files " usage &&
+ test_expect_code 129 nongit git ls-files -h >usage &&
+ test_grep "[Uu]sage: git ls-files " usage
+'
+
test_done
diff --git a/t/t3004-ls-files-basic.sh b/t/t3004-ls-files-basic.sh
index 4034a5a59f..a1078f8701 100755
--- a/t/t3004-ls-files-basic.sh
+++ b/t/t3004-ls-files-basic.sh
@@ -34,13 +34,6 @@ test_expect_success 'ls-files -h in corrupt repository' '
test_grep "[Uu]sage: git ls-files " broken/usage
'
-test_expect_success 'ls-files does not crash with -h' '
- test_expect_code 129 git ls-files -h >usage &&
- test_grep "[Uu]sage: git ls-files " usage &&
- test_expect_code 129 nongit git ls-files -h >usage &&
- test_grep "[Uu]sage: git ls-files " usage
-'
-
test_expect_success SYMLINKS 'ls-files with absolute paths to symlinks' '
mkdir subs &&
ln -s nosuch link &&
--
2.50.0
next prev parent reply other threads:[~2025-07-06 21:41 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 21:41 [PATCH v2 0/7] move builtin help test to t1517 Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 1/7] t/t1517: move checkout-index -h " Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 2/7] t/t1517: move for-each-ref " Usman Akinyemi
2025-07-06 21:41 ` Usman Akinyemi [this message]
2025-07-06 21:41 ` [PATCH v2 4/7] t/t1517: move pack-refs " Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 5/7] t/t1517: move send-pack " Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 6/7] t/t1517: move verify-commit " Usman Akinyemi
2025-07-06 21:41 ` [PATCH v2 7/7] t/t1517: move verify-tag " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v2 0/7] move builtin help " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 1/7] t/t1517: move checkout-index -h " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 2/7] t/t1517: move for-each-ref " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 3/7] t/t1517: move ls-files " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 4/7] t/t1517: move pack-refs " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 5/7] t/t1517: move send-pack " Usman Akinyemi
2025-07-06 21:50 ` [PATCH v3 6/7] t/t1517: move verify-commit " Usman Akinyemi
2025-07-07 16:12 ` Junio C Hamano
2025-07-10 22:59 ` Usman Akinyemi
2025-07-11 16:37 ` Junio C Hamano
2025-07-21 11:55 ` [PATCH v4 0/2] refactor t1517 to focus on help output outside a repository Usman Akinyemi
2025-07-21 11:55 ` [PATCH v4 1/2] t/t1517: automate `git subcmd -h` tests " Usman Akinyemi
2025-07-26 14:34 ` D. Ben Knoble
2025-07-26 21:53 ` Usman Akinyemi
2025-07-30 21:14 ` D. Ben Knoble
2025-07-28 15:08 ` Junio C Hamano
2025-08-02 19:56 ` D. Ben Knoble
2025-08-03 1:27 ` Usman Akinyemi
2025-07-26 14:37 ` D. Ben Knoble
2025-07-26 14:52 ` D. Ben Knoble
2025-07-26 21:51 ` Usman Akinyemi
2025-07-30 21:15 ` D. Ben Knoble
2025-07-28 15:09 ` Junio C Hamano
2025-08-26 15:57 ` Phillip Wood
2025-08-28 13:47 ` D. Ben Knoble
2025-08-29 13:05 ` Phillip Wood
2025-08-29 13:22 ` D. Ben Knoble
2025-08-29 16:31 ` Junio C Hamano
2025-08-30 3:49 ` Usman Akinyemi
2025-07-21 11:55 ` [PATCH v4 2/2] t5200: move `update-server-info -h` test from t1517 Usman Akinyemi
2025-07-26 16:02 ` D. Ben Knoble
2025-08-03 2:07 ` [PATCH V5 0/3] refactor t1517 to focus on help output outside a repository Usman Akinyemi
2025-08-03 2:07 ` [PATCH V5 1/3] t/t1517: automate `git subcmd -h` tests " Usman Akinyemi
2025-08-03 14:52 ` D. Ben Knoble
2025-08-03 17:39 ` Junio C Hamano
2025-08-06 7:20 ` Usman Akinyemi
2025-08-03 2:07 ` [PATCH V5 2/3] t5200: move `update-server-info -h` test from t1517 Usman Akinyemi
2025-08-03 2:07 ` [PATCH V5 3/3] t5304: move `prune " Usman Akinyemi
2025-08-08 1:06 ` [PATCH v6 0/3] refactor t1517 to focus on help output outside a repository Usman Akinyemi
2025-08-08 1:06 ` [PATCH v6 1/3] t/t1517: automate `git subcmd -h` tests " Usman Akinyemi
2025-08-08 1:06 ` [PATCH v6 2/3] t5200: move `update-server-info -h` test from t1517 Usman Akinyemi
2025-08-08 1:06 ` [PATCH v6 3/3] t5304: move `prune " Usman Akinyemi
2025-08-08 14:53 ` [PATCH v6 0/3] refactor t1517 to focus on help output outside a repository Junio C Hamano
2025-08-09 14:46 ` D. Ben Knoble
2025-07-06 21:50 ` [PATCH v3 7/7] t/t1517: move verify-tag -h test to t1517 Usman Akinyemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250706214108.714499-4-usmanakinyemi202@gmail.com \
--to=usmanakinyemi202@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).