git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: git@vger.kernel.org
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Subject: [PATCH v3 2/5] bswap.h: Define GIT_LITTLE_ENDIAN on msvc as little endian
Date: Tue, 15 Jul 2025 21:12:27 +0200	[thread overview]
Message-ID: <20250715191230.12081-3-sebastian@breakpoint.cc> (raw)
In-Reply-To: <20250715191230.12081-1-sebastian@breakpoint.cc>

The Microsoft Visual C++ (MSVC) compiler (as of Visual Studio 2022
version 17.13.6) does not define __BYTE_ORDER__ and its C-library does
not define __BYTE_ORDER. The compiler is supported only on arm64 and x86
which are all little endian.

Define GIT_BYTE_ORDER on msvc as little endian to avoid further checks.

Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
 compat/bswap.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/compat/bswap.h b/compat/bswap.h
index 0a457542dd76a..fd604d9f7b74b 100644
--- a/compat/bswap.h
+++ b/compat/bswap.h
@@ -81,6 +81,10 @@ static inline uint64_t git_bswap64(uint64_t x)
 #define bswap32(x) _byteswap_ulong(x)
 #define bswap64(x) _byteswap_uint64(x)
 
+#define GIT_LITTLE_ENDIAN 1234
+#define GIT_BIG_ENDIAN 4321
+#define GIT_BYTE_ORDER GIT_LITTLE_ENDIAN
+
 #endif
 
 #if defined(bswap32)
@@ -122,7 +126,7 @@ static inline uint64_t git_bswap64(uint64_t x)
 # define GIT_LITTLE_ENDIAN __ORDER_LITTLE_ENDIAN__
 # define GIT_BIG_ENDIAN __ORDER_BIG_ENDIAN__
 
-#else
+#elif !defined(GIT_BYTE_ORDER)
 
 # define GIT_BIG_ENDIAN 4321
 # define GIT_LITTLE_ENDIAN 1234
-- 
2.50.0


  parent reply	other threads:[~2025-07-15 19:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15 19:12 [PATCH v3 0/5] bswap.h: Rework ntohl handling Sebastian Andrzej Siewior
2025-07-15 19:12 ` [PATCH v3 1/5] bswap.h: Add support for __BYTE_ORDER__ Sebastian Andrzej Siewior
2025-07-15 19:12 ` Sebastian Andrzej Siewior [this message]
2025-07-15 19:12 ` [PATCH v3 3/5] bswap.h: Always overwrite ntohl/ ntohll macros Sebastian Andrzej Siewior
2025-07-15 19:12 ` [PATCH v3 4/5] bswap.h: Remove optimized x86 version of bswap32/64 Sebastian Andrzej Siewior
2025-07-15 19:12 ` [PATCH v3 5/5] bswap.h: Provide a built-in based version of bswap32/64 if possible Sebastian Andrzej Siewior
2025-07-15 21:52 ` [PATCH v3 0/5] bswap.h: Rework ntohl handling Junio C Hamano
2025-07-15 22:36   ` brian m. carlson
2025-07-16  5:01   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250715191230.12081-3-sebastian@breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).