From: Hoyoung Lee <lhywkd22@gmail.com>
To: git@vger.kernel.org
Cc: Hoyoung Lee <lhywkd22@gmail.com>
Subject: [PATCH 0/4] Fix resource leaks in various helpers and builtin commands
Date: Tue, 22 Jul 2025 07:36:30 +0000 [thread overview]
Message-ID: <20250722073634.1080217-1-lhywkd22@gmail.com> (raw)
This patch series fixes several cases where file descriptors were not
properly closed on error paths. The changes affect helper programs and
a builtin command, and ensure that system resources are correctly
released before returning from the function.
Each fix is minimal and follows the existing style of the surrounding
code. These changes help improve the robustness of the code by avoiding
potential file descriptor leaks.
Hoyoung Lee (4):
t/helper/test-truncate: close file descriptor after truncation
builtin/archive: close file descriptor on dup2() failure
t/helper/test-delta: close fd if fstat() fails after open()
t/helper/test-delta: close fd if fstat() fails after second open()
builtin/archive.c | 1 +
t/helper/test-delta.c | 3 +++
t/helper/test-truncate.c | 3 +++
3 files changed, 7 insertions(+)
--
2.34.1
next reply other threads:[~2025-07-22 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 7:36 Hoyoung Lee [this message]
2025-07-22 7:36 ` [PATCH 1/4] t/helper/test-truncate: close file descriptor after truncation Hoyoung Lee
2025-07-22 7:36 ` [PATCH 2/4] builtin/archive: close file descriptor on dup2() failure Hoyoung Lee
2025-07-22 7:36 ` [PATCH 3/4] t/helper/test-delta: close fd if fstat() fails after open() Hoyoung Lee
2025-07-22 7:36 ` [PATCH 4/4] t/helper/test-delta: close fd if fstat() fails after second open() Hoyoung Lee
-- strict thread matches above, loose matches on Subject: below --
2025-07-22 8:12 [PATCH 0/4] Fix resource leaks in various helpers and builtin commands Hoyoung Lee
2025-07-22 8:35 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250722073634.1080217-1-lhywkd22@gmail.com \
--to=lhywkd22@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).