git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hoyoung Lee <lhywkd22@gmail.com>
To: git@vger.kernel.org
Cc: Hoyoung Lee <lhywkd22@gmail.com>
Subject: [PATCH v3 0/2] fix resource leaks in test helpers
Date: Tue, 22 Jul 2025 17:41:00 +0000	[thread overview]
Message-ID: <20250722174102.1876197-1-lhywkd22@gmail.com> (raw)

Thanks for the detailed and thoughtful reviews. Your comments helped me better understand how resource cleanup should be handled, especially when dealing with early program termination.

I especially appreciate your in-depth explanation regarding the difference between true resource leaks and stack-unwinding cases. The example you gave was very insightful, and it clarified how automated tools and reviewers should assess whether a resource is truly leaked. Thank you for taking the time to provide such a clear and instructive explanation.

Hoyoung Lee (2):
  t/helper/test-truncate: close file descriptor after truncation
  t/helper/test-delta: fix possible resource leak and ensure safe
    cleanup

 t/helper/test-delta.c    | 9 +++++----
 t/helper/test-truncate.c | 3 +++
 2 files changed, 8 insertions(+), 4 deletions(-)

-- 
2.34.1


             reply	other threads:[~2025-07-22 17:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 17:41 Hoyoung Lee [this message]
2025-07-22 17:41 ` [PATCH v3 1/2] t/helper/test-truncate: close file descriptor after truncation Hoyoung Lee
2025-07-22 21:48   ` Junio C Hamano
2025-07-22 17:41 ` [PATCH v3 2/2] t/helper/test-delta: fix possible resource leak and ensure safe cleanup Hoyoung Lee
2025-07-23  7:28   ` Eric Sunshine
2025-07-23  7:55     ` Jeff King
2025-07-23  8:06       ` Jeff King
2025-07-23  8:17         ` Eric Sunshine
2025-07-23 23:59         ` Jeff King
2025-07-24  0:00           ` [PATCH 1/3] test-delta: handle errors with die() Jeff King
2025-07-24  0:02           ` [PATCH 2/3] test-delta: use strbufs to hold input files Jeff King
2025-07-24  0:03           ` [PATCH 3/3] test-delta: close output descriptor after use Jeff King
2025-07-23  8:11       ` [PATCH v3 2/2] t/helper/test-delta: fix possible resource leak and ensure safe cleanup Eric Sunshine
2025-07-23  8:46         ` Jeff King
2025-07-23 16:37           ` Eric Sunshine
2025-07-23 17:11         ` Junio C Hamano
2025-07-23 16:48       ` Junio C Hamano
2025-07-23 16:44     ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2025-07-22 17:48 [PATCH v3 0/2] fix resource leaks in test helpers Hoyoung Lee
2025-07-22 17:50 Hoyoung Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722174102.1876197-1-lhywkd22@gmail.com \
    --to=lhywkd22@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).