From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: Karthik Nayak <karthik.188@gmail.com>, ps@pks.im, jltobler@gmail.com
Subject: [PATCH 0/4] refs: cleanup code around optimizations
Date: Wed, 15 Oct 2025 23:25:05 +0200 [thread overview]
Message-ID: <20251015-refs-code-cleanup-v1-0-550fdd8a3b41@gmail.com> (raw)
This is extracted from a recent series I sent [1], which I've since
dropped to follow up with a different approach. I think these patches
hold value individually.
They mostly cleanup code around 'git refs optimize' which was added
recently in db0babf9b2 (Merge branch 'ms/refs-optimize', 2025-10-02).
The code in the refs subsystem contains both 'pack-refs' and 'optimize'
functions, which are one and the same.
This series unifies this to only retain the 'optimize' functions and
naming, since it backend generic.
This is based on top of master 143f58ef75 (Sync with Git 2.51.1,
2025-10-15) with 'ps/ref-peeled-tags' merged in.
[1]: 20251010-562-add-option-to-check-if-reference-backend-needs-repacking-v1-0-c7962be584fa@gmail.com
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
pack-refs.c | 8 ++++----
refs.c | 8 +-------
refs.h | 24 +++++++++---------------
refs/debug.c | 8 ++++----
refs/files-backend.c | 22 ++++++----------------
refs/packed-backend.c | 6 +++---
refs/refs-internal.h | 5 +----
refs/reftable-backend.c | 15 ++++-----------
t/pack-refs-tests.sh | 2 --
t/t0601-reffiles-pack-refs.sh | 2 ++
t/t1463-refs-optimize.sh | 2 ++
11 files changed, 36 insertions(+), 66 deletions(-)
Karthik Nayak (4):
refs: move to using the '.optimize' functions
refs: cleanup code around optimization
refs: rename 'pack_refs_opts' to 'refs_optimize_opts'
t/pack-refs-tests: move the 'test_done' to callees
base-commit: 854a80fd48848f942c4a566c9880dc5f089887af
change-id: 20251015-refs-code-cleanup-871a7ce7c8dd
Thanks
- Karthik
next reply other threads:[~2025-10-15 21:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 21:25 Karthik Nayak [this message]
2025-10-15 21:25 ` [PATCH 1/4] refs: move to using the '.optimize' functions Karthik Nayak
2025-10-15 22:05 ` Justin Tobler
2025-10-16 10:37 ` Patrick Steinhardt
2025-10-16 12:07 ` Karthik Nayak
2025-10-16 12:11 ` Patrick Steinhardt
2025-10-16 12:03 ` Karthik Nayak
2025-10-15 21:25 ` [PATCH 2/4] refs: cleanup code around optimization Karthik Nayak
2025-10-15 22:09 ` Justin Tobler
2025-10-15 21:25 ` [PATCH 3/4] refs: rename 'pack_refs_opts' to 'refs_optimize_opts' Karthik Nayak
2025-10-15 22:18 ` Justin Tobler
2025-10-16 12:15 ` Karthik Nayak
2025-10-15 21:25 ` [PATCH 4/4] t/pack-refs-tests: move the 'test_done' to callees Karthik Nayak
2025-10-16 10:38 ` [PATCH 0/4] refs: cleanup code around optimizations Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015-refs-code-cleanup-v1-0-550fdd8a3b41@gmail.com \
--to=karthik.188@gmail.com \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).