From: Jeff King <peff@peff.net>
To: Rostislav Krasny <rostiprodev@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Subject: Re: [PATCH 1/1] compat: modernize and simplify byte swapping functions
Date: Wed, 14 Jan 2026 16:14:09 -0500 [thread overview]
Message-ID: <20260114211409.GA1010080@coredump.intra.peff.net> (raw)
In-Reply-To: <CAKU3Xk5kCEDU7JZBhb6a46dZ=gEkP4neCNLMHXVB4RDnYZHG0w@mail.gmail.com>
On Mon, Jan 12, 2026 at 12:05:22AM +0200, Rostislav Krasny wrote:
> Did you decide something about this pull request? Should I improve it
> and send v2?
I don't have a strong opinion on it. To some degree, it feels a bit like
code churn, because I do not recall anybody complaining particularly
about the current implementation (and as we saw, it ends up as bswap
either way). But maybe others feel differently.
-Peff
next prev parent reply other threads:[~2026-01-14 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 0:27 [PATCH 0/1] compat: modernize and simplify byte swapping functions Rostislav Krasny
2026-01-02 0:27 ` [PATCH 1/1] " Rostislav Krasny
2026-01-02 6:16 ` Jeff King
2026-01-02 17:37 ` Rostislav Krasny
2026-01-11 22:05 ` Rostislav Krasny
2026-01-14 21:14 ` Jeff King [this message]
2026-01-02 7:29 ` [PATCH 0/1] " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114211409.GA1010080@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rostiprodev@gmail.com \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox