From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Subject: [PATCH 0/3] Rename commit list functions to conform to coding guidelines
Date: Thu, 15 Jan 2026 10:35:31 +0100 [thread overview]
Message-ID: <20260115-pks-commit-list-coding-guidelines-v1-0-c58868dbf412@pks.im> (raw)
Hi,
I've been working with commit lists quite often recently, and every
single time I get bitten by the fact that a subset of its functions do
not conform to our coding guidelines. While most of the functions start
with `commit_list_*()`, three functions don't. This patch series fixes
this issue and renames the remaining three functions so that all of them
start with `commit_list_*()`.
Note that I'm adding compatibility wrappers for the old prototypes to
ease the transition and not make life hard for any in-flight patch
series. I've also dropped all changes that lead to conflicts with
"seen".
This series is built on top of 8745eae506 (The 17th batch, 2026-01-11).
Thanks!
Patrick
---
Patrick Steinhardt (3):
commit: rename `copy_commit_list()` to conform to coding guidelines
commit: rename `reverse_commit_list()` to conform to coding guidelines
commit: rename `free_commit_list()` to conform to coding guidelines
bisect.c | 12 ++++++------
blame.c | 2 +-
builtin/am.c | 2 +-
builtin/commit-tree.c | 2 +-
builtin/commit.c | 4 ++--
builtin/describe.c | 2 +-
builtin/diff-tree.c | 2 +-
builtin/gc.c | 2 +-
builtin/log.c | 12 ++++++------
builtin/merge-base.c | 14 +++++++-------
builtin/merge-tree.c | 4 ++--
builtin/merge.c | 16 ++++++++--------
builtin/pull.c | 8 ++++----
builtin/rebase.c | 4 ++--
builtin/rev-list.c | 2 +-
builtin/show-branch.c | 2 +-
builtin/stash.c | 12 ++++++------
commit-graph.c | 2 +-
commit-reach.c | 30 +++++++++++++++---------------
commit.c | 16 ++++++++--------
commit.h | 25 ++++++++++++++++++++++---
contrib/coccinelle/free.cocci | 8 ++++----
diff-lib.c | 2 +-
fmt-merge-msg.c | 2 +-
line-log.c | 2 +-
log-tree.c | 2 +-
merge-ort-wrappers.c | 2 +-
merge-ort.c | 6 +++---
notes-merge.c | 4 ++--
notes-utils.c | 2 +-
object-name.c | 8 ++++----
pack-bitmap-write.c | 6 +++---
ref-filter.c | 8 ++++----
reflog.c | 4 ++--
remote.c | 2 +-
revision.c | 36 ++++++++++++++++++------------------
sequencer.c | 20 ++++++++++----------
shallow.c | 4 ++--
submodule.c | 4 ++--
t/helper/test-reach.c | 10 +++++-----
40 files changed, 163 insertions(+), 144 deletions(-)
---
base-commit: 8745eae506f700657882b9e32b2aa00f234a6fb6
change-id: 20260107-pks-commit-list-coding-guidelines-51d03de0d39d
next reply other threads:[~2026-01-15 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 9:35 Patrick Steinhardt [this message]
2026-01-15 9:35 ` [PATCH 1/3] commit: rename `copy_commit_list()` to conform to coding guidelines Patrick Steinhardt
2026-01-15 9:35 ` [PATCH 2/3] commit: rename `reverse_commit_list()` " Patrick Steinhardt
2026-01-15 9:35 ` [PATCH 3/3] commit: rename `free_commit_list()` " Patrick Steinhardt
2026-01-15 13:32 ` [PATCH 0/3] Rename commit list functions " Junio C Hamano
2026-01-16 6:54 ` Patrick Steinhardt
2026-01-16 16:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115-pks-commit-list-coding-guidelines-v1-0-c58868dbf412@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox