From: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
To: hoda.s.salim@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH] [GSoC][PATCH] t9160: modernize test path checking
Date: Mon, 2 Feb 2026 13:46:57 +0000 [thread overview]
Message-ID: <20260202134657.15320-1-pushkarkumarsingh1970@gmail.com> (raw)
In-Reply-To: <CAAGT0iKRA++yUcCxyRLZN14jLV0xNVSXcKr=F5vJ48dXVEn6PQ@mail.gmail.com>
Hi Hoda,
Welcome!
I took a quick look. The replacements with test_path_is_file, test_path_is_dir, and test_file_not_empty look appropriate here, and the patch itself seems straightforward.
Minor nits:
- I noticed "subsqeuent" is misspelled in a couple of the existing test descriptions (not introduced by this patch, but might be a nice follow-up cleanup).
- You might also consider dropping the duplicated [PATCH] tag in the subject for cleanliness.
Otherwise, this looks like a reasonable microproject.
Best,
Pushkar
next prev parent reply other threads:[~2026-02-02 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 13:36 [PATCH] [GSoC][PATCH] t9160:modernize test path checking Hoda Salim
2026-02-02 13:46 ` Pushkar Singh [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-05 14:59 Hoda Salim via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202134657.15320-1-pushkarkumarsingh1970@gmail.com \
--to=pushkarkumarsingh1970@gmail.com \
--cc=git@vger.kernel.org \
--cc=hoda.s.salim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox