From: "D. Ben Knoble" <ben.knoble+github@gmail.com>
To: git@vger.kernel.org
Cc: "D. Ben Knoble" <ben.knoble+github@gmail.com>,
Denton Liu <liu.denton@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] completion: add stash import, export
Date: Sat, 7 Feb 2026 16:59:16 -0500 [thread overview]
Message-ID: <20260207215924.28863-1-ben.knoble+github@gmail.com> (raw)
These newer commands lack completion; implement basic support for
options and arguments.
Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
---
Notes (benknoble/commits):
- t/t9902-completion.sh passes
- advice on completing the --to-ref argument welcome, but I also think
it's acceptable to not offer any completion there
I happened to build this off of next, but it applies cleanly to master
(which is probably the most appropriate base).
contrib/completion/git-completion.bash | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 538dff1ee5..a8e7c6ddbf 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -3465,7 +3465,7 @@ _git_sparse_checkout ()
_git_stash ()
{
- local subcommands='push list show apply clear drop pop create branch'
+ local subcommands='push list show apply clear drop pop create branch import export'
local subcommand="$(__git_find_on_cmdline "$subcommands save")"
if [ -z "$subcommand" ]; then
@@ -3491,6 +3491,9 @@ _git_stash ()
show,--*)
__gitcomp_builtin stash_show "$__git_diff_common_options"
;;
+ export,--*)
+ __gitcomp_builtin stash_export "--print --to-ref"
+ ;;
*,--*)
__gitcomp_builtin "stash_$subcommand"
;;
@@ -3502,7 +3505,10 @@ _git_stash ()
| sed -n -e 's/:.*//p')"
fi
;;
- show,*|apply,*|drop,*|pop,*)
+ import,*)
+ __git_complete_refs
+ ;;
+ show,*|apply,*|drop,*|pop,*|export,*)
__gitcomp_nl "$(__git stash list \
| sed -n -e 's/:.*//p')"
;;
base-commit: 2a3d6836805534f45cf545da7be25ce1c759c514
--
2.52.0.rc0.971.g305ecc6b61.dirty
next reply other threads:[~2026-02-07 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 21:59 D. Ben Knoble [this message]
2026-02-08 1:33 ` [PATCH] completion: add stash import, export Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260207215924.28863-1-ben.knoble+github@gmail.com \
--to=ben.knoble+github@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox