public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Amisha Chhajed <amishhhaaaa@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, stolee@gmail.com, peff@peff.net,
	avarab@gmail.com, Amisha Chhajed <amishhhaaaa@gmail.com>
Subject: [PATCH 0/2] clean leftover calls to string_list_remove_duplicates
Date: Thu, 12 Feb 2026 09:40:15 +0530	[thread overview]
Message-ID: <20260212041017.91370-1-amishhhaaaa@gmail.com> (raw)

replace calls to string_list_remove_duplicates with string_list_sort_u.

sorted behavior of &keys_uniq depends on the call to string_list_sort on
&keys before &keys is processed to form &keys_uniq, this introduces an
edge case where &keys_uniq will not be sorted as expected, follow [1]
to reproduce.
add string_list_sort_u to &keys_uniq to fix this edge case and ensure
future enhancements to the processing logic does not introduce regressions.

[1]
run command:
cat <<'EOF' >> Documentation/config/add.adoc
aa*.b::
aa.b::
EOF
from git/ and then make test, this sees one failure when the test compared
actual output with sort -u output.

Amisha Chhajed (2):
  sparse-checkout: use string_list_sort_u
  help: ensure &keys_uniq follows sort -u

 builtin/help.c            | 2 +-
 builtin/sparse-checkout.c | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

-- 
2.52.0


             reply	other threads:[~2026-02-12  4:10 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12  4:10 Amisha Chhajed [this message]
2026-02-12  4:10 ` [PATCH 1/2] sparse-checkout: use string_list_sort_u Amisha Chhajed
2026-02-12 19:30   ` Junio C Hamano
2026-02-12  4:10 ` [PATCH 2/2] help: ensure &keys_uniq follows sort -u Amisha Chhajed
2026-02-12 19:58   ` Junio C Hamano
2026-02-12 21:29     ` Amisha Chhajed
2026-02-12 21:37       ` Junio C Hamano
2026-02-13  3:37 ` [PATCH v2 1/2] sparse-checkout: use string_list_sort_u Amisha Chhajed
2026-02-13  3:37   ` [PATCH v2 2/2] help: cleanup the contruction of keys_uniq Amisha Chhajed
2026-02-13  4:30     ` Junio C Hamano
2026-02-13  5:02       ` Eric Sunshine
2026-02-13 16:57         ` Junio C Hamano
2026-02-21 16:28       ` Amisha Chhajed
2026-02-21 16:23 ` [PATCH v3 1/2] sparse-checkout: use string_list_sort_u Amisha Chhajed
2026-02-21 16:23   ` [PATCH v3 2/2] help: cleanup the contruction of keys_uniq Amisha Chhajed
2026-02-22  5:05     ` Junio C Hamano
2026-02-22  9:47       ` Amisha Chhajed
2026-02-26 16:45         ` Junio C Hamano
2026-02-28 10:51           ` Amisha Chhajed
2026-03-02 16:06             ` Junio C Hamano
2026-02-22  2:44   ` [PATCH v3 1/2] sparse-checkout: use string_list_sort_u Junio C Hamano
2026-02-28 10:46 ` [PATCH v4 0/1] Make keys_uniq stop depending on sort of keys_uniq Amisha Chhajed
2026-02-28 10:46   ` [PATCH v4 1/1] help: cleanup the contruction " Amisha Chhajed
2026-03-02 16:04     ` Junio C Hamano
2026-03-11 19:48       ` Amisha Chhajed
2026-03-11 21:11         ` Junio C Hamano
2026-03-11 21:39           ` Eric Sunshine
2026-03-11 21:50             ` Junio C Hamano
2026-03-11 21:54               ` Eric Sunshine
2026-03-11 19:24 ` [PATCH v5] " Amisha Chhajed
2026-03-11 19:46   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260212041017.91370-1-amishhhaaaa@gmail.com \
    --to=amishhhaaaa@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox