From: Ashwani Kumar Kamal <ashwanikamal.im421@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Ashwani Kumar Kamal <ashwanikamal.im421@gmail.com>
Subject: [GSOC PATCH] t9812: modernize test path helpers
Date: Thu, 12 Feb 2026 11:15:30 +0530 [thread overview]
Message-ID: <20260212054530.4763-1-ashwanikamal.im421@gmail.com> (raw)
Replace assertion-style 'test -f' checks with Git's
test_path_is_file() helper for clearer failures and
consistency.
Signed-off-by: Ashwani Kumar Kamal <ashwanikamal.im421@gmail.com>
---
t/t9812-git-p4-wildcards.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t9812-git-p4-wildcards.sh b/t/t9812-git-p4-wildcards.sh
index 254a7c2446..e91004ee79 100755
--- a/t/t9812-git-p4-wildcards.sh
+++ b/t/t9812-git-p4-wildcards.sh
@@ -30,13 +30,13 @@ test_expect_success 'wildcard files git p4 clone' '
test_when_finished cleanup_git &&
(
cd "$git" &&
- test -f file-wild#hash &&
+ test_path_is_file file-wild#hash &&
if test_have_prereq !MINGW,!CYGWIN
then
- test -f file-wild\*star
+ test_path_is_file file-wild\*star
fi &&
- test -f file-wild@at &&
- test -f file-wild%percent
+ test_path_is_file file-wild@at &&
+ test_path_is_file file-wild%percent
)
'
--
2.39.5
reply other threads:[~2026-02-12 5:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212054530.4763-1-ashwanikamal.im421@gmail.com \
--to=ashwanikamal.im421@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox