public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
To: git@vger.kernel.org
Cc: ps@pks.im, gitster@pobox.com, jltobler@gmail.com,
	avila.jn@gmail.com,
	Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Subject: [PATCH 6/8] t1901: use tr in git repo structure output instead of expected value
Date: Wed, 18 Feb 2026 18:08:42 -0300	[thread overview]
Message-ID: <20260218211845.96009-7-lucasseikioshiro@gmail.com> (raw)
In-Reply-To: <20260218211845.96009-1-lucasseikioshiro@gmail.com>

The test 'keyvalue and nul format', as it description says, test both
keyvalue and nul format. These formats are similar, differing only in
their field separator (= in the former, LF in the latter) and their
record separator (LF in the former, NUL in the latter). This way, both
formats can be tested using the same expected output and only replacing
the separators in one of the output formats.

Adjust the output of `git repo structure --format=nul` in t1901, matching the
--format=keyvalue ones. Compare this output against the same value expected
from --format=keyvalue.

Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---
 t/t1901-repo-structure.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/t/t1901-repo-structure.sh b/t/t1901-repo-structure.sh
index a6f2591d9a..4de795181f 100755
--- a/t/t1901-repo-structure.sh
+++ b/t/t1901-repo-structure.sh
@@ -145,18 +145,18 @@ test_expect_success SHA1 'lines and nul format' '
 		test_cmp expect out &&
 		test_line_count = 0 err &&
 
-		# Replace key and value delimiters for nul format.
-		tr "\n=" "\0\n" <expect >expect_nul &&
 		git repo structure --format=nul >out 2>err &&
+		tr "\012" "=" <out | tr "\000" "\012" >actual &&
 
-		test_cmp expect_nul out &&
+		test_cmp expect actual &&
 		test_line_count = 0 err &&
 
 		# "-z", as a synonym to "--format=nul", participates in the
 		# usual "last one wins" rule.
 		git repo structure --format=table -z >out 2>err &&
+		tr "\012" "=" <out | tr "\000" "\012" >actual &&
 
-		test_cmp expect_nul out &&
+		test_cmp expect actual &&
 		test_line_count = 0 err
 	)
 '
-- 
2.50.1 (Apple Git-155)


  parent reply	other threads:[~2026-02-18 21:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 21:08 [PATCH 0/8] repo: refactoring leftover nits Lucas Seiki Oshiro
2026-02-18 21:08 ` [PATCH 1/8] CodingGuidelines: instruct to name arrays in singular Lucas Seiki Oshiro
2026-02-19  3:29   ` Eric Sunshine
2026-02-22 21:43     ` Lucas Seiki Oshiro
2026-02-18 21:08 ` [PATCH 2/8] repo: rename repo_info_fields to repo_info_field Lucas Seiki Oshiro
2026-02-18 21:08 ` [PATCH 3/8] repo: replace get_value_fn_for_key by get_repo_info_field Lucas Seiki Oshiro
2026-02-18 21:08 ` [PATCH 4/8] repo: rename struct field to repo_info_field Lucas Seiki Oshiro
2026-02-18 21:08 ` [PATCH 5/8] t1900: rename t1900-repo to t1900-repo-info Lucas Seiki Oshiro
2026-02-18 21:08 ` Lucas Seiki Oshiro [this message]
2026-02-20 10:12   ` [PATCH 6/8] t1901: use tr in git repo structure output instead of expected value Patrick Steinhardt
2026-02-22 22:35     ` Lucas Seiki Oshiro
2026-02-18 21:08 ` [PATCH 7/8] Documentation/git-repo: replace 'NUL' with '_NUL_' Lucas Seiki Oshiro
2026-02-18 21:08 ` [PATCH 8/8] Documentation/git-repo: capitalize format descriptions Lucas Seiki Oshiro
2026-02-25 16:32 ` [PATCH v2 0/8] repo: refactoring leftover nits Lucas Seiki Oshiro
2026-02-25 16:32   ` [PATCH v2 1/8] CodingGuidelines: instruct to name arrays in singular Lucas Seiki Oshiro
2026-02-25 16:32   ` [PATCH v2 2/8] repo: rename repo_info_fields to repo_info_field Lucas Seiki Oshiro
2026-02-25 16:32   ` [PATCH v2 3/8] repo: replace get_value_fn_for_key by get_repo_info_field Lucas Seiki Oshiro
2026-02-25 16:32   ` [PATCH v2 4/8] repo: rename struct field to repo_info_field Lucas Seiki Oshiro
2026-02-25 16:32   ` [PATCH v2 5/8] t1900: rename t1900-repo to t1900-repo-info Lucas Seiki Oshiro
2026-02-25 16:32   ` [PATCH v2 6/8] t1901: adjust nul format output instead of expected value Lucas Seiki Oshiro
2026-02-25 16:32   ` [PATCH v2 7/8] Documentation/git-repo: replace 'NUL' with '_NUL_' Lucas Seiki Oshiro
2026-02-25 16:32   ` [PATCH v2 8/8] Documentation/git-repo: capitalize format descriptions Lucas Seiki Oshiro
2026-02-25 18:43   ` [PATCH v2 0/8] repo: refactoring leftover nits Lucas Seiki Oshiro
2026-02-25 19:51   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260218211845.96009-7-lucasseikioshiro@gmail.com \
    --to=lucasseikioshiro@gmail.com \
    --cc=avila.jn@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jltobler@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox